Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 873003003: Speed up mergetraces.py. (Closed)

Created:
5 years, 10 months ago by Benoit L
Modified:
5 years, 10 months ago
Reviewers:
pasko
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Speed up mergetraces.py. list -> set, O(n^2) -> O(n). Timing, without this patch (on a typical trace from a device): real 1m49.774s user 1m49.394s sys 0m0.316s With: real 0m5.607s user 0m5.482s sys 0m0.120s BUG=448054 Committed: https://crrev.com/e45ccdcce7af6e91ca25f0660c1339b044c9ed3a Cr-Commit-Position: refs/heads/master@{#313513}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/cygprofile/mergetraces.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benoit L
5 years, 10 months ago (2015-01-28 14:36:17 UTC) #2
pasko
oops, good catch, lgtm++ !!
5 years, 10 months ago (2015-01-28 14:38:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/873003003/1
5 years, 10 months ago (2015-01-28 14:39:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 15:14:02 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 15:16:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e45ccdcce7af6e91ca25f0660c1339b044c9ed3a
Cr-Commit-Position: refs/heads/master@{#313513}

Powered by Google App Engine
This is Rietveld 408576698