Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 872993005: dm: allow multiple --images flags, allow single files (Closed)

Created:
5 years, 10 months ago by hal.canary
Modified:
5 years, 10 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

dm: allow multiple --images flags, allow single files Committed: https://skia.googlesource.com/skia/+/23b03c3c5a79d624c12bd1af5d11ba87967c53e2

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M dm/DM.cpp View 1 chunk +18 lines, -11 lines 2 comments Download

Messages

Total messages: 7 (2 generated)
hal.canary
ptal
5 years, 10 months ago (2015-01-30 16:57:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872993005/1
5 years, 10 months ago (2015-01-30 17:45:47 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-01-30 17:45:48 UTC) #5
scroggo
lgtm https://codereview.chromium.org/872993005/diff/1/dm/DM.cpp File dm/DM.cpp (right): https://codereview.chromium.org/872993005/diff/1/dm/DM.cpp#newcode141 dm/DM.cpp:141: const char* flag = FLAGS_images[i]; nit: flag -> ...
5 years, 10 months ago (2015-01-30 17:57:22 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 17:59:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/23b03c3c5a79d624c12bd1af5d11ba87967c53e2

Powered by Google App Engine
This is Rietveld 408576698