Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 872973003: Make InitializeMojo() idempotent. (Closed)

Created:
5 years, 11 months ago by Hajime Morrita
Modified:
5 years, 11 months ago
Reviewers:
agl, sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make InitializeMojo() idempotent. For tests, there are some difficulties to guarantee it being called just once. This is a retake of https://codereview.chromium.org/866973004/, which didn't work with some tests. R=agl@chromium.org, sky@chromium.org TEST=RenderThreadImplBrowserTest BUG= Committed: https://crrev.com/e7522209c42fda9d0ded8e766bbe79cc187c3a30 Cr-Commit-Position: refs/heads/master@{#313139}

Patch Set 1 #

Patch Set 2 : Updated #

Total comments: 1

Patch Set 3 : Landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -7 lines) Patch
M content/app/mojo/mojo_init.cc View 1 2 2 chunks +18 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
Hajime Morrita
5 years, 11 months ago (2015-01-26 18:59:03 UTC) #1
agl
Why not make the underlying InitializeMojo() call Just Work, even if called multiple times like ...
5 years, 11 months ago (2015-01-26 19:08:50 UTC) #2
Hajime Morrita
On 2015/01/26 19:08:50, agl wrote: > Why not make the underlying InitializeMojo() call Just Work, ...
5 years, 11 months ago (2015-01-26 19:55:00 UTC) #3
agl
lgtm https://codereview.chromium.org/872973003/diff/20001/content/app/mojo/mojo_init.cc File content/app/mojo/mojo_init.cc (right): https://codereview.chromium.org/872973003/diff/20001/content/app/mojo/mojo_init.cc#newcode27 content/app/mojo/mojo_init.cc:27: base::LazyInstance<MojoInitializer> mojo_initializer; I suspect that you want base::LazyInstance<MojoInitializer>::Leaky. ...
5 years, 11 months ago (2015-01-26 20:02:47 UTC) #4
sky
LGTM
5 years, 11 months ago (2015-01-26 20:10:30 UTC) #5
Hajime Morrita
On 2015/01/26 20:02:47, agl wrote: > lgtm > > https://codereview.chromium.org/872973003/diff/20001/content/app/mojo/mojo_init.cc > File content/app/mojo/mojo_init.cc (right): > ...
5 years, 11 months ago (2015-01-26 20:32:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872973003/40001
5 years, 11 months ago (2015-01-26 20:34:09 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-26 21:27:05 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 21:28:31 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e7522209c42fda9d0ded8e766bbe79cc187c3a30
Cr-Commit-Position: refs/heads/master@{#313139}

Powered by Google App Engine
This is Rietveld 408576698