Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 872923002: libwebp: cherry-pick lossless decoding fix (Closed)

Created:
5 years, 11 months ago by jzern
Modified:
5 years, 11 months ago
Reviewers:
urvang
CC:
chromium-reviews, jzern, skal, urvang, vikasa
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

libwebp: cherry-pick lossless decoding fix 783a8cd Regression fix for lossless decoding Regression fix for lossless decoding Reported here: https://code.google.com/p/webp/issues/detail?id=239 At the beginning of method 'DecodeImageData', pixels up to 'dec->last_pixel_' are assumed to be already cached. So, at the end of previous call to that method also, that assumption should hold true. Hence, we should cache all pixels up to 'src' regardless of 'src_last'. This affects lossless incremental decoding only, as that is when src_last and src_end differ. Note: alpha decoding is implicitly incremental, as alpha decoding of only the rows 'y_end - y_start' happens during FinishRow() call. So, this bug affects alpha decoding in non-incremental decoding flow as well. This bug was introduced in: https://gerrit.chromium.org/gerrit/#/c/59716. BUG= Committed: https://crrev.com/a92494b71a1a99292c32bf2b363cc5cf9fe30ac9 Cr-Commit-Position: refs/heads/master@{#312966}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/libwebp/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libwebp/dec/vp8l.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
jzern
5 years, 11 months ago (2015-01-23 21:57:55 UTC) #2
urvang
lgtm
5 years, 11 months ago (2015-01-23 22:00:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872923002/1
5 years, 11 months ago (2015-01-23 22:02:03 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 11 months ago (2015-01-23 22:02:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872923002/1
5 years, 11 months ago (2015-01-23 22:29:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 23:40:52 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 23:42:40 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a92494b71a1a99292c32bf2b363cc5cf9fe30ac9
Cr-Commit-Position: refs/heads/master@{#312966}

Powered by Google App Engine
This is Rietveld 408576698