[PATCH 2/11] ozone: evdev: Move KeyboardEvdev usage during dispatch to EventFactoryEvdev

ui/events/ozone/evdev/event_dispatch_callback.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_EVENTS_OZONE_EVDEV_EVENT_DISPATCH_CALLBACK_H_
 #define UI_EVENTS_OZONE_EVDEV_EVENT_DISPATCH_CALLBACK_H_
 
 #include "base/callback.h"
 #include "base/time/time.h"
 #include "ui/events/event_constants.h"
 #include "ui/gfx/geometry/point_f.h"
 #include "ui/gfx/geometry/vector2d_f.h"
 
 namespace base {
 class TimeDelta;
 }
 
 namespace gfx {
 class PointF;
 class Vector2dF;
 }
 
 namespace ui {
 
 class Event;
 
 typedef base::Callback<void(scoped_ptr<Event>)> EventDispatchCallback;
 
+typedef base::Callback<void(int device_id, unsigned int code, bool down)>

[alexst (slow to review), 2015/01/26 22:18:25]

My brain wants more structure here. 

You are passing things individually in one place, but as a struct in another. I
know there is an interface down the road that replaces these, but similarly, it
splits between the two styles.

I gather it's a callback param limit thing, but since we are bumping against it
in one place, would you hate me if I asked we moved all of these to structs?

[spang, 2015/01/26 23:01:21]

We could remove the structs once the 7 argument limit is removed. There is a
patch for this in review.

Why make more structs just to remove them?

[spang, 2015/01/27 21:31:54]

Done.

+    KeyEventDispatchCallback;
+
 struct TouchEventParams {
   TouchEventParams(int device_id,
                    int touch_id,
                    EventType type,
                    const gfx::PointF& location,
                    const gfx::Vector2dF& radii,
                    float pressure,
                    const base::TimeDelta& timestamp);
   TouchEventParams(const TouchEventParams& other);
   ~TouchEventParams();
 
   int device_id;
   int touch_id;
   EventType type;
   gfx::PointF location;
   gfx::Vector2dF radii;
   float pressure;
   base::TimeDelta timestamp;
 };
 
 typedef base::Callback<void(const TouchEventParams& params)>
     TouchEventDispatchCallback;
 
 }  // namspace ui
 
 #endif  // UI_EVENTS_OZONE_EVDEV_EVENT_DISPATCH_CALLBACK_H_