Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 872883002: [chromedriver] Generate as much filler text as needed for testMoveToElementAndClick (Closed)

Created:
5 years, 11 months ago by samuong
Modified:
5 years, 11 months ago
Reviewers:
stgao
CC:
chromium-reviews, samuong+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@multiline-mac
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Generate as much filler text as needed for testMoveToElementAndClick BUG= Committed: https://crrev.com/6bf3192b1dc84ab54371e80e13dce93c90cd3e4a Cr-Commit-Position: refs/heads/master@{#313106}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M chrome/test/data/chromedriver/multiline.html View 1 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
samuong
crbug.com/866113002 fixed it on win7, but broke it on android. I don't think there's a ...
5 years, 11 months ago (2015-01-23 20:23:46 UTC) #2
stgao
lgtm if the cl is well-tested.
5 years, 11 months ago (2015-01-24 01:57:56 UTC) #3
samuong
On 2015/01/24 01:57:56, Shuotao wrote: > lgtm if the cl is well-tested. I've tested this ...
5 years, 11 months ago (2015-01-26 18:54:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872883002/20001
5 years, 11 months ago (2015-01-26 18:55:34 UTC) #6
stgao
On 2015/01/26 18:54:30, samuong wrote: > On 2015/01/24 01:57:56, Shuotao wrote: > > lgtm if ...
5 years, 11 months ago (2015-01-26 19:09:24 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-26 20:04:44 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 20:05:32 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6bf3192b1dc84ab54371e80e13dce93c90cd3e4a
Cr-Commit-Position: refs/heads/master@{#313106}

Powered by Google App Engine
This is Rietveld 408576698