Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 872843002: GuestView: Fix unhandled keyboard events. (Closed)

Created:
5 years, 11 months ago by Fady Samuel
Modified:
5 years, 11 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GuestView: Fix unhandled keyboard events. Unhandled keyboard events should not use the guest as source. In the case of the OOP PDF viewer, if devtools for the guest was open, unhandled keyboard events would go there and would be applied to the guest by devtools instead of to the embedder. The solution is to use the embedder WebContents as the source for the unhandled keyboard event. BUG=450929 Committed: https://crrev.com/996d23ef2304a937dacd728fd0eeec4252d64bca Cr-Commit-Position: refs/heads/master@{#312881}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M extensions/browser/guest_view/guest_view_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Fady Samuel
5 years, 11 months ago (2015-01-23 17:26:08 UTC) #2
lazyboy
lgtm
5 years, 11 months ago (2015-01-23 17:27:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872843002/1
5 years, 11 months ago (2015-01-23 17:27:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 18:23:32 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 18:24:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/996d23ef2304a937dacd728fd0eeec4252d64bca
Cr-Commit-Position: refs/heads/master@{#312881}

Powered by Google App Engine
This is Rietveld 408576698