Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: tests/lib/async/zone_empty_description2_test.dart

Issue 87283003: Make the root zone's schduleMicrotask and create[Periodic]Timer bind the callback. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Changed tests. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/async/zone_bind_test.dart ('k') | tests/lib/async/zone_empty_description_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/async/zone_empty_description2_test.dart
diff --git a/tests/lib/async/zone_empty_description2_test.dart b/tests/lib/async/zone_empty_description2_test.dart
index 68e145399a4248737e65112f3b693eba4f8c8241..8fd4ad1fe4016be019d6f4b4590a8e7ba8cd8a2c 100644
--- a/tests/lib/async/zone_empty_description2_test.dart
+++ b/tests/lib/async/zone_empty_description2_test.dart
@@ -14,8 +14,8 @@ testEmptyZoneSpecification() {
asyncStart();
bool timerDidRun = false;
forked.createTimer(const Duration(milliseconds: 20), () {
- // The createTimer functions on the Zone don't bind the closures.
- Expect.identical(Zone.ROOT, Zone.current);
+ // The createTimer functions on the Zone binds the closures.
floitsch 2013/11/27 10:05:15 s/functions/function
+ Expect.identical(forked, Zone.current);
timerDidRun = true;
asyncEnd();
});
@@ -29,8 +29,8 @@ testEmptyZoneSpecification() {
timer.cancel();
asyncEnd();
}
- // The createPeriodicTimer functions on the Zone don't bind the closures.
- Expect.identical(Zone.ROOT, Zone.current);
+ // The createPeriodicTimer functions on the Zone binds the closures.
floitsch 2013/11/27 10:05:15 ditto.
+ Expect.identical(forked, Zone.current);
});
Expect.identical(Zone.ROOT, Zone.current);
}
« no previous file with comments | « tests/lib/async/zone_bind_test.dart ('k') | tests/lib/async/zone_empty_description_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698