Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5151)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.h

Issue 872813003: Add Rappor metrics for Safe Browsing and SSL interstitials. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fit nit: Remove _MAX from enum Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.h
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.h b/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
index 27ee2e6be716e7f090dc59f49c8ae0c7bf225f9a..424e516767f21073544df397dcb2e730f8ea38a4 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
@@ -34,8 +34,8 @@
#include "base/gtest_prod_util.h"
#include "base/task/cancelable_task_tracker.h"
+#include "chrome/browser/interstitials/security_interstitial_metrics_helper.h"
#include "chrome/browser/interstitials/security_interstitial_page.h"
-#include "chrome/browser/interstitials/security_interstitial_uma_helper.h"
#include "chrome/browser/safe_browsing/ui_manager.h"
#include "url/gurl.h"
@@ -191,10 +191,10 @@ class SafeBrowsingBlockingPage : public SecurityInterstitialPage {
void PopulateHarmfulLoadTimeData(base::DictionaryValue* load_time_data);
void PopulatePhishingLoadTimeData(base::DictionaryValue* load_time_data);
- std::string GetHistogramPrefix() const;
+ std::string GetMetricPrefix() const;
std::string GetSamplingEventName() const;
- scoped_ptr<SecurityInterstitialUmaHelper> uma_helper_;
+ scoped_ptr<SecurityInterstitialMetricsHelper> metrics_helper_;
DISALLOW_COPY_AND_ASSIGN(SafeBrowsingBlockingPage);
};

Powered by Google App Engine
This is Rietveld 408576698