compiler/java/com/google/dart/compiler/resolver/SyntheticDefaultConstructorElement.java - Issue 8728001: Support for 'abstract' modifier for class and spec recommended warnings, issue 375

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/SyntheticDefaultConstructorElement.java

Issue 8728001: Support for 'abstract' modifier for class and spec recommended warnings, issue 375 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Merge. Warning for factory constructor of abstract class. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/DynamicElementImplementation.java ('k') | compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/SyntheticDefaultConstructorElement.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/SyntheticDefaultConstructorElement.java b/compiler/java/com/google/dart/compiler/resolver/SyntheticDefaultConstructorElement.java

index 16ba358acfdae69015a9ebb158da2869f0db8858..65e485719eb1b98a05500d027a1d6e7d1b3c17bf 100644

--- a/compiler/java/com/google/dart/compiler/resolver/SyntheticDefaultConstructorElement.java

+++ b/compiler/java/com/google/dart/compiler/resolver/SyntheticDefaultConstructorElement.java

@@ -29,13 +29,17 @@ public class SyntheticDefaultConstructorElement implements ConstructorElement {

CoreTypeProvider typeProvider) {

this.method = method;

this.enclosingClass = enclosingClass;

- this.functionType =

- Types.makeFunctionType(

- null,

- typeProvider.getFunctionType().getElement(),

- getParameters(),

- typeProvider.getDynamicType(),

- Collections.<TypeVariable>emptyList());

+ if (typeProvider != null) {

+ this.functionType =

+ Types.makeFunctionType(

+ null,

+ typeProvider.getFunctionType().getElement(),

+ getParameters(),

+ typeProvider.getDynamicType(),

+ Collections.<TypeVariable>emptyList());

+ } else {

+ functionType = null;

+ }

}

@Override