Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 872783003: Use upload test to get uirobot test id. (Closed)

Created:
5 years, 11 months ago by rnephew (Reviews Here)
Modified:
5 years, 11 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use upload test to get uirobot test id. BUG= Committed: https://crrev.com/3932d125d7a8c73e41fc1f768d5ea443f349aa9d Cr-Commit-Position: refs/heads/master@{#312946}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M build/android/pylib/remote/device/remote_device_test_run.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/remote/device/remote_device_uirobot_test_run.py View 1 1 chunk +22 lines, -1 line 0 comments Download
M build/android/test_runner.py View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
rnephew (Wrong account)
5 years, 11 months ago (2015-01-23 19:04:27 UTC) #2
jbudorick
lgtm w/ nit https://codereview.chromium.org/872783003/diff/1/build/android/pylib/remote/device/remote_device_uirobot_test_run.py File build/android/pylib/remote/device/remote_device_uirobot_test_run.py (right): https://codereview.chromium.org/872783003/diff/1/build/android/pylib/remote/device/remote_device_uirobot_test_run.py#newcode65 build/android/pylib/remote/device/remote_device_uirobot_test_run.py:65: test_upload_res, 'Unable to get UiRobot test ...
5 years, 11 months ago (2015-01-23 19:07:04 UTC) #3
rnephew (Wrong account)
https://codereview.chromium.org/872783003/diff/1/build/android/pylib/remote/device/remote_device_uirobot_test_run.py File build/android/pylib/remote/device/remote_device_uirobot_test_run.py (right): https://codereview.chromium.org/872783003/diff/1/build/android/pylib/remote/device/remote_device_uirobot_test_run.py#newcode65 build/android/pylib/remote/device/remote_device_uirobot_test_run.py:65: test_upload_res, 'Unable to get UiRobot test id.') On 2015/01/23 ...
5 years, 11 months ago (2015-01-23 19:22:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872783003/20001
5 years, 11 months ago (2015-01-23 21:18:20 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-23 22:20:47 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 22:21:51 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/3932d125d7a8c73e41fc1f768d5ea443f349aa9d
Cr-Commit-Position: refs/heads/master@{#312946}

Powered by Google App Engine
This is Rietveld 408576698