Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 872773008: Move WeakPtrFactory member last in class (Closed)

Created:
5 years, 10 months ago by hans
Modified:
5 years, 10 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move WeakPtrFactory member last in class It was failing like this: In file included from ../../media/mojo/services/mojo_cdm_service.cc:5: ../../media/mojo/services/mojo_cdm_service.h:71:40: error: [chromium-style] WeakPtrFactory members which refer to their outer class must be the last member in the outer class definition. base::WeakPtrFactory<MojoCdmService> weak_factory_; ^ BUG=444089 Committed: https://crrev.com/fd1627878734662118298121717c21043b59e1da Cr-Commit-Position: refs/heads/master@{#313796}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/mojo/services/mojo_cdm_service.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
hans
This blocks the Clang roll, please take a look.
5 years, 10 months ago (2015-01-29 20:45:23 UTC) #2
DaleCurtis
lgtm
5 years, 10 months ago (2015-01-29 20:52:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872773008/1
5 years, 10 months ago (2015-01-29 20:57:06 UTC) #5
dmichael (off chromium)
lgtm too. Surprised this only turned up on the roll.
5 years, 10 months ago (2015-01-29 20:57:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 21:32:37 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 21:33:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd1627878734662118298121717c21043b59e1da
Cr-Commit-Position: refs/heads/master@{#313796}

Powered by Google App Engine
This is Rietveld 408576698