Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1456)

Side by Side Diff: src/ic/handler-compiler.cc

Issue 872723003: Load getter from map descriptor instead of embedding it in handler. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add mips, mips64, x87 Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/handler-compiler.h ('k') | src/ic/ia32/handler-compiler-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/ic/call-optimization.h" 7 #include "src/ic/call-optimization.h"
8 #include "src/ic/handler-compiler.h" 8 #include "src/ic/handler-compiler.h"
9 #include "src/ic/ic.h" 9 #include "src/ic/ic.h"
10 #include "src/ic/ic-inl.h" 10 #include "src/ic/ic-inl.h"
(...skipping 335 matching lines...) Expand 10 before | Expand all | Expand 10 after
346 case LookupIterator::ACCESSOR: 346 case LookupIterator::ACCESSOR:
347 Handle<ExecutableAccessorInfo> info = 347 Handle<ExecutableAccessorInfo> info =
348 Handle<ExecutableAccessorInfo>::cast(it->GetAccessors()); 348 Handle<ExecutableAccessorInfo>::cast(it->GetAccessors());
349 DCHECK_NE(NULL, info->getter()); 349 DCHECK_NE(NULL, info->getter());
350 GenerateLoadCallback(reg, info); 350 GenerateLoadCallback(reg, info);
351 } 351 }
352 } 352 }
353 353
354 354
355 Handle<Code> NamedLoadHandlerCompiler::CompileLoadViaGetter( 355 Handle<Code> NamedLoadHandlerCompiler::CompileLoadViaGetter(
356 Handle<Name> name, Handle<JSFunction> getter) { 356 Handle<Name> name, int accessor_index, int expected_arguments) {
357 Frontend(name); 357 Register holder = Frontend(name);
358 GenerateLoadViaGetter(masm(), type(), receiver(), getter); 358 GenerateLoadViaGetter(masm(), type(), receiver(), holder, accessor_index,
359 expected_arguments);
359 return GetCode(kind(), Code::FAST, name); 360 return GetCode(kind(), Code::FAST, name);
360 } 361 }
361 362
362 363
363 // TODO(verwaest): Cleanup. holder() is actually the receiver. 364 // TODO(verwaest): Cleanup. holder() is actually the receiver.
364 Handle<Code> NamedStoreHandlerCompiler::CompileStoreTransition( 365 Handle<Code> NamedStoreHandlerCompiler::CompileStoreTransition(
365 Handle<Map> transition, Handle<Name> name) { 366 Handle<Map> transition, Handle<Name> name) {
366 Label miss; 367 Label miss;
367 368
368 // Check that we are allowed to write this. 369 // Check that we are allowed to write this.
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
488 DCHECK(elements_kind == DICTIONARY_ELEMENTS); 489 DCHECK(elements_kind == DICTIONARY_ELEMENTS);
489 cached_stub = LoadDictionaryElementStub(isolate()).GetCode(); 490 cached_stub = LoadDictionaryElementStub(isolate()).GetCode();
490 } 491 }
491 } 492 }
492 493
493 handlers->Add(cached_stub); 494 handlers->Add(cached_stub);
494 } 495 }
495 } 496 }
496 } 497 }
497 } // namespace v8::internal 498 } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ic/handler-compiler.h ('k') | src/ic/ia32/handler-compiler-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698