Issue 872713006: Fix more {virtual,override,final} build failures for CrOS build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 872713006: Fix more {virtual,override,final} build failures for CrOS build. (Closed)

Created:
5 years, 11 months ago by dcheng

Modified:
5 years, 11 months ago

Reviewers:
yukawa

CC:
chromium-reviews, nona+watch_chromium.org, oshima+watch_chromium.org, penghuang+watch_chromium.org, stevenjb+watch_chromium.org, James Su, yukishiino+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix more {virtual,override,final} build failures for CrOS build. BUG=417463 TBR=yukawa@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/461c8c81f644038cffe89a801b62f4d36fcf9f1e

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -12 lines)			Patch
	M	ui/base/ime/chromeos/ime_keyboard_ozone.h	View		1 chunk	+11 lines, -12 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/461c8c81f644038cffe89a801b62f4d36fcf9f1e Cr-Commit-Position: refs/heads/master@{#313001}

5 years, 11 months ago (2015-01-24 03:39:48 UTC) #3

dcheng

Committed patchset #1 (id:1) manually as 461c8c81f644038cffe89a801b62f4d36fcf9f1e (tree was closed).

5 years, 11 months ago (2015-01-24 03:39:56 UTC) #4

yukawa

5 years, 11 months ago (2015-01-26 01:19:56 UTC) #5

Message was sent while issue was closed.

On 2015/01/24 03:39:56, dcheng wrote:
> Committed patchset #1 (id:1) manually as
> 461c8c81f644038cffe89a801b62f4d36fcf9f1e (tree was closed).

lgtm.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages