Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 872713005: autofill - Keep showing form preview while card unmasking prompt is up. (Closed)

Created:
5 years, 11 months ago by Evan Stade
Modified:
5 years, 11 months ago
Reviewers:
jschuh, brettw
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

autofill - Keep showing form preview while card unmasking prompt is up. This used to work, but was broken by d0a0c992fc0eb9c81d514a BUG=none Committed: https://crrev.com/929baf93d518ac898a91c264f69e82dc97a37cff Cr-Commit-Position: refs/heads/master@{#313317}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M components/autofill/content/browser/content_autofill_driver.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M components/autofill/content/common/autofill_messages.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
Evan Stade
5 years, 11 months ago (2015-01-24 01:43:34 UTC) #2
Evan Stade
brettw for review, jschuh for ipc messages change (which is deletion only)
5 years, 11 months ago (2015-01-24 01:44:08 UTC) #4
brettw
lgtm
5 years, 11 months ago (2015-01-26 05:59:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872713005/20001
5 years, 11 months ago (2015-01-26 17:51:46 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/38321) Try jobs failed on following ...
5 years, 11 months ago (2015-01-26 17:58:11 UTC) #9
Evan Stade
On 2015/01/26 17:58:11, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 11 months ago (2015-01-27 02:13:15 UTC) #10
jschuh
ipc security lgtm (notes: message removal)
5 years, 11 months ago (2015-01-27 18:29:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872713005/20001
5 years, 11 months ago (2015-01-27 18:49:25 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/38321)
5 years, 11 months ago (2015-01-27 18:50:05 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872713005/20001
5 years, 11 months ago (2015-01-27 18:55:06 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-27 18:56:41 UTC) #18
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 18:58:02 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/929baf93d518ac898a91c264f69e82dc97a37cff
Cr-Commit-Position: refs/heads/master@{#313317}

Powered by Google App Engine
This is Rietveld 408576698