Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 872683006: [PATCH 3/11] ozone: evdev: Move MouseButtonMap usage during dispatch to EventFactoryEvdev (Closed)

Created:
5 years, 11 months ago by spang
Modified:
5 years, 10 months ago
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Move MouseButtonMap usage during dispatch to EventFactoryEvdev This is part of a series moving IO on evdev devices to a fast thread, since UI thread is too slow for the cursor. The mouse button map is a UI thread object, so move all of the mouse processing that needs button map information outside of the device-specific object. Devices no longer get a MouseButtonMapEvdev* since they will execute on a different thread. BUG=449710 TEST=boot link_freon & click mouse Committed: https://crrev.com/8d667bbac1ca8c96387b3e60259aae2cf02aa569 Cr-Commit-Position: refs/heads/master@{#313425}

Patch Set 1 #

Patch Set 2 : updates for events_unittests #

Patch Set 3 : update per comments on previous patches #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -151 lines) Patch
M ui/events/ozone/evdev/event_converter_evdev_impl.h View 2 chunks +13 lines, -14 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev_impl.cc View 1 2 4 chunks +9 lines, -29 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev_impl_unittest.cc View 1 2 6 chunks +55 lines, -34 lines 0 comments Download
M ui/events/ozone/evdev/event_dispatch_callback.h View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_dispatch_callback.cc View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.h View 1 2 2 chunks +7 lines, -4 lines 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.cc View 1 2 5 chunks +54 lines, -5 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.h View 4 chunks +11 lines, -11 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_interpreter_libevdev_cros.cc View 1 2 7 chunks +21 lines, -54 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
spang
5 years, 11 months ago (2015-01-23 21:57:25 UTC) #2
alexst (slow to review)
lgtm, I know my nits are addressed in the following patches.
5 years, 10 months ago (2015-01-27 15:17:14 UTC) #3
spang
5 years, 10 months ago (2015-01-27 19:32:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872683006/40001
5 years, 10 months ago (2015-01-28 01:33:48 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-01-28 04:07:30 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 04:09:42 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8d667bbac1ca8c96387b3e60259aae2cf02aa569
Cr-Commit-Position: refs/heads/master@{#313425}

Powered by Google App Engine
This is Rietveld 408576698