Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 872683005: Add missing NULL checks to NativeViewAccessibilityWin. (Closed)

Created:
5 years, 11 months ago by dmazzoni
Modified:
5 years, 10 months ago
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing NULL checks to NativeViewAccessibilityWin. IAccessible objects are reference-counted, so the COM object may persist if the view is deleted. We should always check the view (which will be nulled when the view is deleted). BUG=436074 Committed: https://crrev.com/6b6714d20c8311b0b0badff0cd783eb6a4bff4bc Cr-Commit-Position: refs/heads/master@{#313792}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M ui/views/accessibility/native_view_accessibility_win.cc View 1 3 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
dmazzoni
5 years, 11 months ago (2015-01-23 19:25:20 UTC) #2
dmazzoni
Adding additional reviewers
5 years, 10 months ago (2015-01-28 21:31:09 UTC) #4
ananta
https://codereview.chromium.org/872683005/diff/1/ui/views/accessibility/native_view_accessibility_win.cc File ui/views/accessibility/native_view_accessibility_win.cc (right): https://codereview.chromium.org/872683005/diff/1/ui/views/accessibility/native_view_accessibility_win.cc#newcode1222 ui/views/accessibility/native_view_accessibility_win.cc:1222: if (!provider) Incorrect check? No provider here,
5 years, 10 months ago (2015-01-28 21:32:37 UTC) #5
dmazzoni
https://codereview.chromium.org/872683005/diff/1/ui/views/accessibility/native_view_accessibility_win.cc File ui/views/accessibility/native_view_accessibility_win.cc (right): https://codereview.chromium.org/872683005/diff/1/ui/views/accessibility/native_view_accessibility_win.cc#newcode1222 ui/views/accessibility/native_view_accessibility_win.cc:1222: if (!provider) On 2015/01/28 21:32:37, ananta wrote: > Incorrect ...
5 years, 10 months ago (2015-01-28 21:47:22 UTC) #6
dmazzoni
Ping
5 years, 10 months ago (2015-01-29 16:46:09 UTC) #7
ananta
lgtm
5 years, 10 months ago (2015-01-29 20:00:28 UTC) #8
cpu_(ooo_6.6-7.5)
lgtm
5 years, 10 months ago (2015-01-29 20:20:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872683005/20001
5 years, 10 months ago (2015-01-29 20:20:49 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-29 21:15:46 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 21:18:05 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6b6714d20c8311b0b0badff0cd783eb6a4bff4bc
Cr-Commit-Position: refs/heads/master@{#313792}

Powered by Google App Engine
This is Rietveld 408576698