Disable the noisiest /analyze warning in Chrome. ~3,700/12,000

include/core/SkMath.h

Index: include/core/SkMath.h
diff --git a/include/core/SkMath.h b/include/core/SkMath.h
index 014f014debb771575af495aad5469498bebbf6cd..884ef22918dfbaa9a2da35c848ef4b7bc487e8d3 100644
--- a/include/core/SkMath.h
+++ b/include/core/SkMath.h
@@ -79,6 +79,11 @@ int SkCLZ_portable(uint32_t);
             if (mask) {
                 DWORD index;
                 _BitScanReverse(&index, mask);
+                // Suppress this bogus /analyze warning. The check for non-zero
+                // guarantees that _BitScanReverse will succeed.
+#ifdef _PREFAST_  // /analyze enabled

[bungeman-skia, 2015/01/30 18:10:54]

I took a look, and it looks like warning 6102 is specifically only an analyzer
warning, so it seems a bit redundant to only disable this warning only when
analyze is enabled (since we're already inside an _MSC_VER ifdef). Can we remove
this ifdef and just always suppress this warning on this line?

+#pragma warning(suppress : 6102) // Using 'index' from failed function call
+#endif
                 return index ^ 0x1F;
             } else {
                 return 32;