Disable the noisiest /analyze warning in Chrome. ~3,700/12,000

include/core/SkMath.h

 
 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #ifndef SkMath_DEFINED
@@ skipping 61 matching lines @@
 int SkCLZ_portable(uint32_t);
 
 #ifndef SkCLZ
     #if defined(_MSC_VER) && _MSC_VER >= 1400
         #include <intrin.h>
 
         static inline int SkCLZ(uint32_t mask) {
             if (mask) {
                 DWORD index;
                 _BitScanReverse(&index, mask);
+                // Suppress this bogus /analyze warning. The check for non-zero
+                // guarantees that _BitScanReverse will succeed.
+#ifdef _PREFAST_

[mtklein, 2015/01/30 16:07:54]

Can't hurt to add '// /analyze enabled'

[brucedawson, 2015/01/30 17:38:06]

Done.

+#pragma warning(disable: 6102) // Using 'index' from failed function call

[bungeman-skia, 2015/01/30 15:49:22]

Can we push and pop this? I feel uncomfortable making this look like it's scoped
here, when it isn't. Since this is in a header, I think this covers the rest of
the translation unit as well.

[brucedawson, 2015/01/30 17:38:06]

Good catch. I meant to use #pragma warning(suppress which only affects the
following line, but I forgot. I've made that change, and confirmed that the
warning remains enabled for the rest of the translation unit.

+#endif
                 return index ^ 0x1F;
             } else {
                 return 32;
             }
         }
     #elif defined(SK_CPU_ARM32) || defined(__GNUC__) || defined(__clang__)
         static inline int SkCLZ(uint32_t mask) {
             // __builtin_clz(0) is undefined, so we have to detect that case.
             return mask ? __builtin_clz(mask) : 32;
         }
@@ skipping 128 matching lines @@
     *div = static_cast<Out>(d);
     *mod = static_cast<Out>(numer-d*denom);
 #else
     // On x86 this will just be a single idiv.
     *div = static_cast<Out>(numer/denom);
     *mod = static_cast<Out>(numer%denom);
 #endif
 }
 
 #endif