Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 872673006: Add .debug file in the list of outputs for PNaCl targets. (Closed)

Created:
5 years, 10 months ago by Sergey Ulanov
Modified:
5 years, 10 months ago
Reviewers:
bradnelson, bradn
CC:
native-client-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Add .debug file in the list of outputs for PNaCl targets. PNaCl targets always generate .debug build file, but it was not listed in the outputs section. Committed: https://chromium.googlesource.com/native_client/src/native_client/+/996ec5e3d098e6491a310f903f468b5d858ebf9c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M build/untrusted.gypi View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Sergey Ulanov
5 years, 10 months ago (2015-01-29 18:53:51 UTC) #2
Sergey Ulanov
I was trying to land https://codereview.chromium.org/872633006/ and it broke the build because .debug wasn't listed ...
5 years, 10 months ago (2015-01-29 18:54:48 UTC) #3
bradn
lgtm
5 years, 10 months ago (2015-02-03 12:49:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872673006/1
5 years, 10 months ago (2015-02-03 17:16:31 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 19:26:40 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/996ec5e3d...

Powered by Google App Engine
This is Rietveld 408576698