Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Unified Diff: chrome/browser/chrome_browser_main_win.cc

Issue 872673002: Do not use win32k renderer lockdown if DirectWrite is disabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move IsWin32kRendererLockdownEnabled to content/common Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/browser_main_loop.cc » ('j') | content/browser/browser_main_loop.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_browser_main_win.cc
diff --git a/chrome/browser/chrome_browser_main_win.cc b/chrome/browser/chrome_browser_main_win.cc
index f3066d1d2c26ed8a1f5d1a64fc68231db455253f..9fcf92d5f92b1347472bd07f4708370d0b24a765 100644
--- a/chrome/browser/chrome_browser_main_win.cc
+++ b/chrome/browser/chrome_browser_main_win.cc
@@ -228,20 +228,6 @@ int ChromeBrowserMainPartsWin::PreCreateThreads() {
chrome::MESSAGE_BOX_TYPE_WARNING);
}
- // Windows 8+ provides a mode where by a process cannot call Win32K/GDI
- // functions in the kernel (win32k.sys). If we are on Windows 8+ and if
- // we are launched with the kEnableWin32kRendererLockDown switch then we
- // force the PDF pepper plugin to run out of process. This is because the
- // PDF plugin uses GDI for text rendering which does not work in the
- // Win32K lockdown mode. Running it out of process ensures that the process
- // launched for the plugin does not have the Win32K lockdown mode enabled.
- // TODO(ananta)
- // Revisit this when the pdf plugin uses skia and stops using GDI.
- if (switches::IsWin32kRendererLockdownEnabled() &&
- base::win::GetVersion() >= base::win::VERSION_WIN8) {
- base::CommandLine::ForCurrentProcess()->AppendSwitch(
- switches::kEnableOutOfProcessPdf);
- }
return rv;
}
@@ -274,8 +260,6 @@ void ChromeBrowserMainPartsWin::PostBrowserStart() {
ChromeBrowserMainParts::PostBrowserStart();
UMA_HISTOGRAM_BOOLEAN("Windows.Tablet", base::win::IsTabletDevice());
- UMA_HISTOGRAM_BOOLEAN("Windows.Win32kRendererLockdown",
- switches::IsWin32kRendererLockdownEnabled());
// Set up a task to verify installed modules in the current process. Use a
// delay to reduce the impact on startup time.
« no previous file with comments | « no previous file | content/browser/browser_main_loop.cc » ('j') | content/browser/browser_main_loop.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698