Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1260)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 872643002: win: 'EnableEnhancedInstructionSet': '5' now enables /arch:AVX2. (Closed)

Created:
5 years, 11 months ago by Nico
Modified:
5 years, 11 months ago
Reviewers:
bradnelson, bradn, scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

win: 'EnableEnhancedInstructionSet': '5' now enables /arch:AVX2. BUG=chromium:451290 R=bradnelson@google.com Committed: https://code.google.com/p/gyp/source/detail?r=2028

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -6 lines) Patch
M pylib/gyp/MSVSSettings.py View 1 chunk +4 lines, -1 line 0 comments Download
M pylib/gyp/msvs_emulation.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M test/win/compiler-flags/enable-enhanced-instruction-set.cc View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M test/win/compiler-flags/enable-enhanced-instruction-set.gyp View 1 chunk +14 lines, -0 lines 0 comments Download
M test/win/gyptest-cl-enable-enhanced-instruction-set.py View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Nico
Please check that this makes sense, I don't really know what I'm doing. https://codereview.chromium.org/872643002/diff/1/test/win/gyptest-cl-enable-enhanced-instruction-set.py File ...
5 years, 11 months ago (2015-01-23 06:37:30 UTC) #2
Nico
+bradn, in case he happens to be around earlier :-)
5 years, 11 months ago (2015-01-23 18:28:31 UTC) #4
bradn
lgtm https://codereview.chromium.org/872643002/diff/20001/test/win/compiler-flags/enable-enhanced-instruction-set.cc File test/win/compiler-flags/enable-enhanced-instruction-set.cc (right): https://codereview.chromium.org/872643002/diff/20001/test/win/compiler-flags/enable-enhanced-instruction-set.cc#newcode13 test/win/compiler-flags/enable-enhanced-instruction-set.cc:13: # if !defined(__AVX__) FWIW, might be clearer if ...
5 years, 11 months ago (2015-01-23 18:31:08 UTC) #6
Nico
https://codereview.chromium.org/872643002/diff/20001/test/win/compiler-flags/enable-enhanced-instruction-set.cc File test/win/compiler-flags/enable-enhanced-instruction-set.cc (right): https://codereview.chromium.org/872643002/diff/20001/test/win/compiler-flags/enable-enhanced-instruction-set.cc#newcode13 test/win/compiler-flags/enable-enhanced-instruction-set.cc:13: # if !defined(__AVX__) On 2015/01/23 18:31:08, bradn wrote: > ...
5 years, 11 months ago (2015-01-23 18:31:44 UTC) #7
bradn
lgtm
5 years, 11 months ago (2015-01-23 18:35:18 UTC) #8
Nico
5 years, 11 months ago (2015-01-23 18:41:42 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as r2028 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698