Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 872633006: Copy debug PNaCl plugin in Dev builds of the chromoting webapp. (Closed)

Created:
5 years, 11 months ago by Sergey Ulanov
Modified:
5 years, 10 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@all
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Copy debug PNaCl plugin in Dev builds of the chromoting webapp. With this change the Debug version of the PNaCl plugin will be copied to the webapp directory allowing to debug PNaCl plugin (using nacl-gdb). Also updated build-webapp.py to process all *.jinja2 input files as jinja2 templates. This patch was previously reverted because of a problem that should be fixed now by https://codereview.chromium.org/872673006/ . BUG=451643 Committed: https://crrev.com/a0f666219c0a8e03e2fd4909cb5fab8859a49462 Cr-Commit-Position: refs/heads/master@{#314873}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -30 lines) Patch
M remoting/remoting_client.gypi View 1 chunk +10 lines, -1 line 0 comments Download
M remoting/webapp/build-webapp.py View 1 chunk +10 lines, -19 lines 0 comments Download
D remoting/webapp/crd/remoting_client_pnacl.nmf View 1 chunk +0 lines, -10 lines 0 comments Download
A + remoting/webapp/crd/remoting_client_pnacl.nmf.jinja2 View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Sergey Ulanov
5 years, 11 months ago (2015-01-24 00:35:44 UTC) #2
Jamie
LGTM
5 years, 11 months ago (2015-01-24 00:50:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872633006/1
5 years, 11 months ago (2015-01-24 18:08:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-24 18:52:04 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/65ffdafc8538b14ad0cbdf6a57d9d21e1e882a9d Cr-Commit-Position: refs/heads/master@{#313024}
5 years, 11 months ago (2015-01-24 18:53:05 UTC) #7
Sergiy Byelozyorov
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/870273002/ by sergiyb@chromium.org. ...
5 years, 11 months ago (2015-01-24 19:29:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872633006/1
5 years, 10 months ago (2015-02-05 20:59:40 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 21:00:59 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 21:01:55 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0f666219c0a8e03e2fd4909cb5fab8859a49462
Cr-Commit-Position: refs/heads/master@{#314873}

Powered by Google App Engine
This is Rietveld 408576698