pkg/analysis_server/lib/src/protocol.dart - Issue 872633002: Use 'print' to send responses/notifications to the client.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/protocol.dart

Issue 872633002: Use 'print' to send responses/notifications to the client. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/ByteResponseStream.java ('K') | « pkg/analysis_server/lib/src/channel/byte_stream_channel.dart ('k') | pkg/analysis_server/lib/src/server/stdio_server.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/protocol.dart

diff --git a/pkg/analysis_server/lib/src/protocol.dart b/pkg/analysis_server/lib/src/protocol.dart

index 95eb38c972a9d7aff2d57dc488c74189b50b6032..4fa3e4c27afc8d82be8138207bc0aa0966a39d9c 100644

--- a/pkg/analysis_server/lib/src/protocol.dart

+++ b/pkg/analysis_server/lib/src/protocol.dart

@@ -469,6 +469,7 @@ class Notification {

Map<String, Object> toJson() {

Map<String, Object> jsonObject = {};

+ jsonObject['time'] = new DateTime.now().millisecondsSinceEpoch;

danrubel 2015/01/23 14:16:53 Good idea, but I already have a pending CL to capt

scheglov 2015/01/23 16:27:40 Done.

jsonObject[EVENT] = event;

if (_params != null) {

jsonObject[PARAMS] = _params;

@@ -829,6 +830,7 @@ class Response {

Map<String, Object> toJson() {

Map<String, Object> jsonObject = new HashMap<String, Object>();

jsonObject[ID] = id;

+ jsonObject['time'] = new DateTime.now().millisecondsSinceEpoch;

danrubel 2015/01/23 14:16:53 Please remove this as described above.

scheglov 2015/01/23 16:27:40 Done.

if (error != null) {

jsonObject[ERROR] = error.toJson();

}