VaapiVEA: Get maximum resolution from libva

content/common/gpu/media/vaapi_wrapper.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file contains an implementation of VaapiWrapper, used by
 // VaapiVideoDecodeAccelerator and VaapiH264Decoder for decode,
 // and VaapiVideoEncodeAccelerator for encode, to interface
 // with libva (VA-API library for hardware video codec).
 
 #ifndef CONTENT_COMMON_GPU_MEDIA_VAAPI_WRAPPER_H_
@@ skipping 27 matching lines @@
 // It is also responsible for managing and freeing VABuffers (not VASurfaces),
 // which are used to queue parameters and slice data to the HW codec,
 // as well as underlying memory for VASurfaces themselves.
 class CONTENT_EXPORT VaapiWrapper {
  public:
   enum CodecMode {
     kDecode,
     kEncode,
   };
 
-  // |report_error_to_uma_cb| will be called independently from reporting
-  // errors to clients via method return values.
+  struct ProfileConfig {
+    media::VideoCodecProfile profile;

[wuchengli, 2015/02/03 03:17:33]

It should be better to store VaProfile in this class. For example, what's the
max decode resolution of Jpeg?

[henryhsu, 2015/02/13 04:01:03]

Done.

+    CodecMode mode;
+    gfx::Size max_resolution;
+  };
+
+  // Return an instance of VaapiWrapper and initialize by |profile| and
+  // |mode|. |report_error_to_uma_cb| will be called independently from
+  // reporting errors to clients via method return values.
   static scoped_ptr<VaapiWrapper> Create(
       CodecMode mode,
       media::VideoCodecProfile profile,
       const base::Closure& report_error_to_uma_cb);
 
-  // Return the supported encode profiles.
-  static std::vector<media::VideoCodecProfile> GetSupportedEncodeProfiles(
-      const base::Closure& report_error_to_uma_cb);
+  // Return the supported profiles according to mode.
+  static std::vector<media::VideoCodecProfile> GetSupportedProfiles(

[wuchengli, 2015/02/03 03:17:33]

Now that we have to return both profile and resolution, make this return
VideoEncodeAccelerator::SupportedProfile. That is, combine GetSupportedProfiles
and GetCodecMaxResolution.

[henryhsu, 2015/02/13 04:01:03]

Done.

+      CodecMode mode);

[wuchengli, 2015/02/03 03:17:33]

No need to add CodecMode parameter in this CL. Decode is not used now. Change
this back to GetSupportedEncodeProfiles.

[henryhsu, 2015/02/13 04:01:04]

Done.

+
+  // Return the hardware supported maximum resolution.
+  static gfx::Size GetCodecMaxResolution(
+      media::VideoCodecProfile profile,
+      CodecMode mode);
 
   ~VaapiWrapper();
 
   // Create |num_surfaces| backing surfaces in driver for VASurfaces, each
   // of size |size|. Returns true when successful, with the created IDs in
   // |va_surfaces| to be managed and later wrapped in VASurfaces.
   // The client must DestroySurfaces() each time before calling this method
   // again to free the allocated surfaces first, but is not required to do so
   // at destruction time, as this will be done automatically from
   // the destructor.
@@ skipping 88 matching lines @@
   // if needed.
   bool BlitSurface(VASurfaceID va_surface_id_src,
                    const gfx::Size& src_size,
                    VASurfaceID va_surface_id_dest,
                    const gfx::Size& dest_size);
 
  private:
   VaapiWrapper();
 
   bool Initialize(CodecMode mode,
-                  media::VideoCodecProfile profile,
-                  const base::Closure& report_error__to_uma_cb);
+                  media::VideoCodecProfile profile);
   void Deinitialize();
   bool VaInitialize(const base::Closure& report_error_to_uma_cb);
   bool GetSupportedVaProfiles(std::vector<VAProfile>* profiles);
   bool IsEntrypointSupported(VAProfile va_profile, VAEntrypoint entrypoint);
   bool AreAttribsSupported(VAProfile va_profile,
                            VAEntrypoint entrypoint,
                            const std::vector<VAConfigAttrib>& required_attribs);
+  bool GetVaCodecMaxResolution(VAConfigID config, gfx::Size* resolution);
 
   // Destroys a |va_surface| created using CreateUnownedSurface.
   void DestroyUnownedSurface(VASurfaceID va_surface_id);
 
   // Initialize the video post processing context with the |size| of
   // the input pictures to be processed.
   bool InitializeVpp_Locked();
 
   // Deinitialize the video post processing context.
   void DeinitializeVpp();
 
   // Execute pending job in hardware and destroy pending buffers. Return false
   // if vaapi driver refuses to accept parameter or slice buffers submitted
   // by client, or if execution fails in hardware.
   bool Execute(VASurfaceID va_surface_id);
 
   // Attempt to set render mode to "render to texture.". Failure is non-fatal.
   void TryToSetVADisplayAttributeToLocalGPU();
 
+  // Initialize all supported profiles.
+  void InitializeSupportedProfiles();
+
   // Lazily initialize static data after sandbox is enabled.  Return false on
   // init failure.
   static bool PostSandboxInitialization();
 
+  // Return an instance of VaapiWrapper. |report_error_to_uma_cb| will be called
+  // independently from reporting errors to clients via method return values.
+  static scoped_ptr<VaapiWrapper> CreateInstance(
+      const base::Closure& report_error_to_uma_cb);
+
   // Libva is not thread safe, so we have to do locking for it ourselves.
   // This lock is to be taken for the duration of all VA-API calls and for
   // the entire job submission sequence in ExecuteAndDestroyPendingBuffers().
   base::Lock va_lock_;
 
   // Allocated ids for VASurfaces.
   std::vector<VASurfaceID> va_surface_ids_;
 
   // The VAAPI version.
   int major_version_, minor_version_;
@@ skipping 19 matching lines @@
   // return values from public methods.
   base::Closure report_error_to_uma_cb_;
 
   // VPP (Video Post Processing) context, this is used to convert
   // pictures used by the decoder to RGBA pictures usable by GL or the
   // display hardware.
   VAConfigID va_vpp_config_id_;
   VAContextID va_vpp_context_id_;
   VABufferID va_vpp_buffer_id_;
 
+  // Initialize supported profiles once.
+  static bool is_initialize_profile_;
+  static ProfileConfig supported_profiles_[media::VIDEO_CODEC_PROFILE_MAX * 2];

[wuchengli, 2015/02/02 09:01:07]

Chromium way to do this is using base::LazyInstance or Singleton.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.html?showone=Stati...

http://www.chromium.org/developers/coding-style/important-abstractions-and-da...

[kcwu, 2015/02/02 10:11:02]

Why not vector? if not vector, the size should be MAX*2+1.

another idea:
supported_profiles_[kCodecModeMax][media::VIDEO_CODEC_PROFILE_MAX+1];
Then you can save one loop later.

[henryhsu, 2015/02/02 10:42:24]

Static variables cannot use class object.

[henryhsu, 2015/02/13 04:01:03]

Done.

[henryhsu, 2015/02/13 04:01:04]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(VaapiWrapper);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_COMMON_GPU_MEDIA_VAAPI_WRAPPER_H_