Issue 872603003: Only release the result of a register request to a tab if it's still the foreground tab when the re…

Issue 872603003: Only release the result of a register request to a tab if it's still the foreground tab when the re… (Closed)

Created:
5 years, 11 months ago by juanlang (chromium.org)

Modified:
5 years, 11 months ago

Reviewers:
xiyuan, Reilly Grant (use Gerrit), Arnar Birgisson

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Only release the result of a register request to a tab if it's still the foreground tab when the result is received. BUG=451165 R=arnarb@chromium.org,reillyg@chromium.org Committed: https://crrev.com/78b0d7352e0bf1ada675f939df7a817842c15ce5 Cr-Commit-Position: refs/heads/master@{#313141}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+134 lines, -41 lines)			Patch
M	chrome/browser/resources/cryptotoken/cryptotokenapprovedorigins.js	View	1 chunk	+19 lines, -27 lines	0 comments	Download
M	chrome/browser/resources/cryptotoken/cryptotokenbackground.js	View	2 chunks	+83 lines, -14 lines	0 comments	Download
M	chrome/browser/resources/cryptotoken/webrequestsender.js	View	1 chunk	+32 lines, -0 lines	0 comments	Download

Total messages: 9 (2 generated)

juanlang (chromium.org)

Xiyuan, would you mind having a quick look? (Rubber stamp ok.)

5 years, 11 months ago (2015-01-26 18:08:38 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872603003/1

5 years, 11 months ago (2015-01-26 20:43:25 UTC) #7

commit-bot: I haz the power

5 years, 11 months ago (2015-01-26 21:43:13 UTC) #9

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/78b0d7352e0bf1ada675f939df7a817842c15ce5
Cr-Commit-Position: refs/heads/master@{#313141}