Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 872493004: fontconfig: Force use of c++ linker (Closed)

Created:
5 years, 10 months ago by spang
Modified:
5 years, 10 months ago
Reviewers:
dnicoara, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

fontconfig: Force use of c++ linker This is really silly, but gyp doesn't seem to track if a static_library contains C++ code and needs a C++ link step. So our copy of libxml breaks us by containing a little bit of (chromium-added) C++ code. This is really a correctness issue in the build system. BUG=445627 TEST=linux_ecs_ozone tryjob Committed: https://crrev.com/0540e174312591a9f9b71e557810869eacd66929 Cr-Commit-Position: refs/heads/master@{#315138}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, --1 lines) Patch
A + third_party/fontconfig/chromium/empty.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/fontconfig/fontconfig.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
spang
5 years, 10 months ago (2015-02-06 22:12:14 UTC) #2
spang
On 2015/02/06 22:12:14, spang wrote: see also http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_ecs_ozone/builds/380/steps/compile%20content_shell/logs/stdio (failed tryjob for https://codereview.chromium.org/900343002/)
5 years, 10 months ago (2015-02-06 22:13:30 UTC) #3
dnicoara
lgtm
5 years, 10 months ago (2015-02-06 22:37:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872493004/1
5 years, 10 months ago (2015-02-06 23:28:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 23:52:28 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0540e174312591a9f9b71e557810869eacd66929 Cr-Commit-Position: refs/heads/master@{#315138}
5 years, 10 months ago (2015-02-06 23:53:00 UTC) #8
Nico
(fyi: Another option is to add -lstdc++: https://codereview.chromium.org/854753002/diff/100001/third_party/mesa/mesa.gyp#newcode690)
5 years, 10 months ago (2015-02-07 00:21:15 UTC) #10
spang
5 years, 10 months ago (2015-02-09 19:00:52 UTC) #11
Message was sent while issue was closed.
On 2015/02/07 00:21:15, Nico wrote:
> (fyi: Another option is to add -lstdc++:
>
https://codereview.chromium.org/854753002/diff/100001/third_party/mesa/mesa.g...)

I thought about that but I feel we should use the right frontend altogether (g++
or clang++). That way there's no need to make any assumptions about toolchain
internals.

Powered by Google App Engine
This is Rietveld 408576698