net/quic/quic_crypto_client_stream.cc - Issue 872483002: Changed verify_details_ check to verify_details_.get() to keep code in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_crypto_client_stream.cc

Issue 872483002: Changed verify_details_ check to verify_details_.get() to keep code in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Removing_an_obselete_TODO_84372263

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_crypto_client_stream.cc

diff --git a/net/quic/quic_crypto_client_stream.cc b/net/quic/quic_crypto_client_stream.cc

index fec38b5c86126568643cfae031aa8f2738fef55a..3ff6dc29fe40ce7fe73b8394d4021f42ad717a1d 100644

--- a/net/quic/quic_crypto_client_stream.cc

+++ b/net/quic/quic_crypto_client_stream.cc

@@ -439,7 +439,7 @@ void QuicCryptoClientStream::DoVerifyProofComplete(

if (!verify_ok_) {

next_state_ = STATE_NONE;

- if (verify_details_) {

+ if (verify_details_.get()) {

client_session()->OnProofVerifyDetailsAvailable(*verify_details_);

}

UMA_HISTOGRAM_BOOLEAN("Net.QuicVerifyProofFailed.HandshakeConfirmed",

« no previous file with comments | « no previous file | no next file » | no next file with comments »