Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Issue 872473004: views: Remove dead code in CustomButton. (Closed)

Created:
5 years, 10 months ago by sadrul
Modified:
5 years, 10 months ago
Reviewers:
tfarina
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

views: Remove dead code in CustomButton. CustomButtonStateChangedDelegate was itnroduced in http://crrev.com/159994, and its use was removed in http://crrev.com/185369 It hasn't been used since. So remove the code. BUG=none R=tfarina@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/40e19b9ba07556773c7fffe76a88f883dae042fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -24 lines) Patch
M ui/views/controls/button/custom_button.h View 3 chunks +0 lines, -22 lines 0 comments Download
M ui/views/controls/button/custom_button.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
sadrul
5 years, 10 months ago (2015-01-26 19:24:11 UTC) #2
tfarina
Confirmed through cs.chromium.org lgtm
5 years, 10 months ago (2015-01-28 14:27:46 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/40e19b9ba07556773c7fffe76a88f883dae042fe Cr-Commit-Position: refs/heads/master@{#313515}
5 years, 10 months ago (2015-01-28 15:29:27 UTC) #4
sadrul
5 years, 10 months ago (2015-01-28 15:30:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
40e19b9ba07556773c7fffe76a88f883dae042fe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698