PlzNavigate: Remove the RequestNavigation IPC

content/common/navigation_params.h

Index: content/common/navigation_params.h
diff --git a/content/common/navigation_params.h b/content/common/navigation_params.h
index b23847c3cbf4e7887da70bd52d6442dc6179d59e..9636f2352ccb02062a603abde12824c650fac2b6 100644
--- a/content/common/navigation_params.h
+++ b/content/common/navigation_params.h
@@ -69,7 +69,6 @@ struct CONTENT_EXPORT CommonNavigationParams {
 };
 
 // Used by FrameMsg_Navigate.
-// PlzNavigate: sent to the renderer when requesting a navigation.
 struct CONTENT_EXPORT RequestNavigationParams {

[nasko, 2015/02/02 21:17:43]

Do we still need this struct if we have removed the IPC?

[clamy, 2015/02/03 16:17:10]

Done.

   RequestNavigationParams();
   RequestNavigationParams(bool is_post,
@@ -88,6 +87,29 @@ struct CONTENT_EXPORT RequestNavigationParams {
   std::vector<unsigned char> browser_initiated_post_data;
 };
 
+// PlzNavigate: parameters needed to start a navigation on the IO thread.
+struct CONTENT_EXPORT BeginNavigationParams {
+  // TODO(clamy): See if it is possible to reuse this in
+  // ResourceMsg_Request_Params.
+  BeginNavigationParams();

[nasko, 2015/02/02 21:17:43]

Should we allow a parameterless constructor? The current version of this
constructor doesn't initialize defaults for method or headers.

[clamy, 2015/02/03 16:17:10]

Actually it seems we need one to pass this struct as an IPC parameter.

+  BeginNavigationParams(std::string method,
+                        std::string headers,
+                        int load_flags,
+                        bool has_user_gesture);
+
+  // The request method: GET, POST, etc.
+  std::string method;
+
+  // Additional HTTP request headers.
+  std::string headers;
+
+  // net::URLRequest load flags (net::LOAD_NORMAL) by default).
+  int load_flags;
+
+  // True if the request was user initiated.
+  bool has_user_gesture;
+};
+
 // Used by FrameMsg_Navigate.
 // PlzNavigate: sent to the renderer when the navigation is ready to commit.
 struct CONTENT_EXPORT CommitNavigationParams {