Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Side by Side Diff: content/browser/loader/navigation_url_loader.h

Issue 872473003: PlzNavigate: Remove the RequestNavigation IPC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Nasko's comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_LOADER_NAVIGATION_URL_LOADER_H_ 5 #ifndef CONTENT_BROWSER_LOADER_NAVIGATION_URL_LOADER_H_
6 #define CONTENT_BROWSER_LOADER_NAVIGATION_URL_LOADER_H_ 6 #define CONTENT_BROWSER_LOADER_NAVIGATION_URL_LOADER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 18 matching lines...) Expand all
29 // |delegate| outlives the loader. |request_body| must not be accessed on the 29 // |delegate| outlives the loader. |request_body| must not be accessed on the
30 // UI thread after this point. 30 // UI thread after this point.
31 // 31 //
32 // TODO(davidben): When navigation is disentangled from the loader, the 32 // TODO(davidben): When navigation is disentangled from the loader, the
33 // request parameters should not come in as a navigation-specific 33 // request parameters should not come in as a navigation-specific
34 // structure. Information like has_user_gesture and 34 // structure. Information like has_user_gesture and
35 // should_replace_current_entry shouldn't be needed at this layer. 35 // should_replace_current_entry shouldn't be needed at this layer.
36 static scoped_ptr<NavigationURLLoader> Create( 36 static scoped_ptr<NavigationURLLoader> Create(
37 BrowserContext* browser_context, 37 BrowserContext* browser_context,
38 int64 frame_tree_node_id, 38 int64 frame_tree_node_id,
39 const CommonNavigationParams& common_params,
40 scoped_ptr<NavigationRequestInfo> request_info, 39 scoped_ptr<NavigationRequestInfo> request_info,
41 ResourceRequestBody* request_body,
42 NavigationURLLoaderDelegate* delegate); 40 NavigationURLLoaderDelegate* delegate);
43 41
44 // For testing purposes; sets the factory for use in testing. 42 // For testing purposes; sets the factory for use in testing.
45 static void SetFactoryForTesting(NavigationURLLoaderFactory* factory); 43 static void SetFactoryForTesting(NavigationURLLoaderFactory* factory);
46 44
47 virtual ~NavigationURLLoader() {} 45 virtual ~NavigationURLLoader() {}
48 46
49 // Called in response to OnRequestRedirected to continue processing the 47 // Called in response to OnRequestRedirected to continue processing the
50 // request. 48 // request.
51 virtual void FollowRedirect() = 0; 49 virtual void FollowRedirect() = 0;
52 50
53 protected: 51 protected:
54 NavigationURLLoader() {} 52 NavigationURLLoader() {}
55 53
56 private: 54 private:
57 DISALLOW_COPY_AND_ASSIGN(NavigationURLLoader); 55 DISALLOW_COPY_AND_ASSIGN(NavigationURLLoader);
58 }; 56 };
59 57
60 } // namespace content 58 } // namespace content
61 59
62 #endif // CONTENT_BROWSER_LOADER_NAVIGATION_URL_LOADER_H_ 60 #endif // CONTENT_BROWSER_LOADER_NAVIGATION_URL_LOADER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698