Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 872453002: Store the accumulated configuration from requestMediaKeySystemAccess(). (Closed)

Created:
5 years, 11 months ago by sandersd (OOO until July 31)
Modified:
5 years, 11 months ago
Reviewers:
jrummell, ddorwin
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Store the accumulated configuration from requestMediaKeySystemAccess(). BUG=447059 Committed: https://crrev.com/3d1434e5dc33c5c994afd3d24e1c22b9c1d121d6 Cr-Commit-Position: refs/heads/master@{#312955}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Fixes. #

Patch Set 3 : Remove 'override' entirely. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -17 lines) Patch
M media/blink/webcontentdecryptionmoduleaccess_impl.h View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M media/blink/webcontentdecryptionmoduleaccess_impl.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M media/blink/webencryptedmediaclient_impl.cc View 1 1 chunk +10 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sandersd (OOO until July 31)
This is the Chromium side, I believe it can be applied cleanly without the Blink ...
5 years, 11 months ago (2015-01-22 22:36:42 UTC) #2
jrummell
lgtm w/nits. I think that "getConfiguration() override;" will prevent this from being submitted until the ...
5 years, 11 months ago (2015-01-23 00:34:32 UTC) #4
sandersd (OOO until July 31)
> I think that "getConfiguration() override;" will prevent this from being submitted Without 'override' it ...
5 years, 11 months ago (2015-01-23 20:05:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872453002/60001
5 years, 11 months ago (2015-01-23 21:49:24 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 11 months ago (2015-01-23 22:52:41 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 22:53:34 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3d1434e5dc33c5c994afd3d24e1c22b9c1d121d6
Cr-Commit-Position: refs/heads/master@{#312955}

Powered by Google App Engine
This is Rietveld 408576698