Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 872443003: Write dm.json periodically instead of only once at the end. (Closed)

Created:
5 years, 11 months ago by mtklein_C
Modified:
5 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Write dm.json periodically instead of only once at the end. This way if a bot crashes, we might get some partial results in gold rather than none. We do the same sort of thing in nanobench for perf. BUG=skia:3255 Committed: https://skia.googlesource.com/skia/+/a17241bd0a59efd6c30a007db8f10274b8f80f26

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M dm/DM.cpp View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
mtklein_C
5 years, 11 months ago (2015-01-22 21:52:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872443003/1
5 years, 11 months ago (2015-01-22 21:52:51 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-22 21:52:52 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-23 00:54:32 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 11 months ago (2015-01-23 06:54:39 UTC) #8
stephana
On 2015/01/23 06:54:39, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
5 years, 11 months ago (2015-01-23 13:25:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872443003/1
5 years, 11 months ago (2015-01-23 13:47:40 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 13:48:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a17241bd0a59efd6c30a007db8f10274b8f80f26

Powered by Google App Engine
This is Rietveld 408576698