chrome/browser/signin/signin_header_helper.cc - Issue 872433006: Disconnect one click sign in code. The code itself will be removed in followup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/signin_header_helper.cc

Issue 872433006: Disconnect one click sign in code. The code itself will be removed in followup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix merge Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/signin/signin_header_helper.cc

diff --git a/chrome/browser/signin/signin_header_helper.cc b/chrome/browser/signin/signin_header_helper.cc

index c4dd4190ed4f99541083f0b388fcc82538ca993d..8909ced265b95d159ac12969148434dbb7bcf686 100644

--- a/chrome/browser/signin/signin_header_helper.cc

+++ b/chrome/browser/signin/signin_header_helper.cc

@@ -214,7 +214,7 @@ bool AppendMirrorRequestHeaderIfPossible(

}

// Only set the header for Drive and Gaia always, and other Google properties

- // if new-profile-management is enabled.

+ // if account consistency is enabled.

// Vasquette, which is integrated with most Google properties, needs the

// header to redirect certain user actions to Chrome native UI. Drive and Gaia

// need the header to tell if the current user is connected. The drive path is

@@ -224,7 +224,6 @@ bool AppendMirrorRequestHeaderIfPossible(

GURL origin(url.GetOrigin());

bool is_enable_account_consistency = switches::IsEnableAccountConsistency();

bool is_google_url =

- !switches::IsEnableWebBasedSignin() &&

is_enable_account_consistency &&

(google_util::IsGoogleDomainUrl(

url,

« no previous file with comments | « chrome/browser/signin/signin_browsertest.cc ('k') | chrome/browser/signin/signin_promo.h » ('j') | no next file with comments »