components/signin/core/browser/about_signin_internals.cc - Issue 872433006: Disconnect one click sign in code. The code itself will be removed in followup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/about_signin_internals.cc

Issue 872433006: Disconnect one click sign in code. The code itself will be removed in followup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/first_run/first_run.cc ('K') | « chrome/test/remoting/remote_desktop_browsertest.cc ('k') | components/signin/core/common/profile_management_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/signin/core/browser/about_signin_internals.cc

diff --git a/components/signin/core/browser/about_signin_internals.cc b/components/signin/core/browser/about_signin_internals.cc

index 3ad5eed155ed5f7f884029605f7750036b34fbce..6008d05b67170eaf70229ac72d38e9f5c6ec85c3 100644

--- a/components/signin/core/browser/about_signin_internals.cc

+++ b/components/signin/core/browser/about_signin_internals.cc

@@ -448,8 +448,6 @@ scoped_ptr<base::DictionaryValue> AboutSigninInternals::SigninStatus::ToValue(

: "Signed In";

AddSectionEntry(basic_info, "Chrome Version", product_version);

AddSectionEntry(basic_info, "Signin Status", signin_status_string);

- AddSectionEntry(basic_info, "Web Based Signin Enabled?",

- switches::IsEnableWebBasedSignin() == true ? "True" : "False");

AddSectionEntry(basic_info, "Webview Based Signin Enabled?",

switches::IsEnableWebviewBasedSignin() == true ? "True" : "False");

AddSectionEntry(basic_info, "New Avatar Menu Enabled?",