Disconnect one click sign in code. The code itself will be removed in followup

chrome/browser/ui/sync/one_click_signin_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/sync/one_click_signin_helper.h"
 
 #include <algorithm>
 #include <functional>
 #include <utility>
 #include <vector>
@@ skipping 210 matching lines @@
 
 // Add a specific email to the list of emails rejected for one-click
 // sign-in, for this profile.
 void AddEmailToOneClickRejectedList(Profile* profile,
                                     const std::string& email) {
   ListPrefUpdate updater(profile->GetPrefs(),
                          prefs::kReverseAutologinRejectedEmailList);
   updater->AppendIfNotPresent(new base::StringValue(email));
 }
 
-void RedirectToNtpOrAppsPageWithIds(int child_id,
-                                    int route_id,
-                                    signin_metrics::Source source) {
-  content::WebContents* web_contents = tab_util::GetWebContentsByID(child_id,
-                                                                    route_id);
-  if (!web_contents)
-    return;
-
-  OneClickSigninHelper::RedirectToNtpOrAppsPage(web_contents, source);
-}
-
 // Start syncing with the given user information.
 void StartSync(const OneClickSigninHelper::StartSyncArgs& args,
                OneClickSigninSyncStarter::StartSyncMode start_mode) {
   if (start_mode == OneClickSigninSyncStarter::UNDO_SYNC) {
     OneClickSigninHelper::LogHistogramValue(signin_metrics::HISTOGRAM_UNDO);
     return;
   }
 
   // The wrapper deletes itself once it's done.
   OneClickSigninHelper::SyncStarterWrapper* wrapper =
@@ skipping 19 matching lines @@
       break;
   }
   if (action != signin_metrics::HISTOGRAM_MAX)
     OneClickSigninHelper::LogHistogramValue(action);
 }
 
 void StartExplicitSync(const OneClickSigninHelper::StartSyncArgs& args,
                        content::WebContents* contents,
                        OneClickSigninSyncStarter::StartSyncMode start_mode,
                        ConfirmEmailDialogDelegate::Action action) {
-  bool enable_inline = !switches::IsEnableWebBasedSignin();
   if (action == ConfirmEmailDialogDelegate::START_SYNC) {
     StartSync(args, start_mode);
-    if (!enable_inline) {
-      // Redirect/tab closing for inline flow is handled by the sync callback.
-      OneClickSigninHelper::RedirectToNtpOrAppsPageIfNecessary(
-          contents, args.source);
-    }
   } else {
     // Perform a redirection to the NTP/Apps page to hide the blank page when
     // the action is CLOSE or CREATE_NEW_USER. The redirection is useful when
     // the action is CREATE_NEW_USER because the "Create new user" page might
     // be opened in a different tab that is already showing settings.
-    if (enable_inline) {
-      // Redirect/tab closing for inline flow is handled by the sync callback.
-      args.callback.Run(OneClickSigninSyncStarter::SYNC_SETUP_FAILURE);
-    } else {
-      // Redirect, but don't do so immediately; otherwise there might be two
-      // nested navigations, which would cause a crash: http://crbug.com/293261
-      // Instead, post a task to the current thread.
-      base::MessageLoopProxy::current()->PostNonNestableTask(
-          FROM_HERE,
-          base::Bind(RedirectToNtpOrAppsPageWithIds,
-                     contents->GetRenderProcessHost()->GetID(),
-                     contents->GetRoutingID(),
-                     args.source));
-    }
+    args.callback.Run(OneClickSigninSyncStarter::SYNC_SETUP_FAILURE);
     if (action == ConfirmEmailDialogDelegate::CREATE_NEW_USER) {
       chrome::ShowSettingsSubPage(args.browser,
                                   std::string(chrome::kCreateProfileSubPage));
     }
   }
 }
 
 void ClearPendingEmailOnIOThread(content::ResourceContext* context) {
   ProfileIOData* io_data = ProfileIOData::FromResourceContext(context);
   DCHECK(io_data);
@@ skipping 130 matching lines @@
 CurrentHistoryCleaner::~CurrentHistoryCleaner() {
 }
 
 void CurrentHistoryCleaner::DidCommitProvisionalLoadForFrame(
     content::RenderFrameHost* render_frame_host,
     const GURL& url,
     ui::PageTransition transition_type) {
   // Return early if this is not top-level navigation.
   if (render_frame_host->GetParent())
     return;
-
-  content::NavigationController* nc = &web_contents()->GetController();
-  HistoryService* hs = HistoryServiceFactory::GetForProfile(
-      Profile::FromBrowserContext(web_contents()->GetBrowserContext()),
-      ServiceAccessType::IMPLICIT_ACCESS);
-
-  // Have to wait until something else gets added to history before removal.
-  if (history_index_to_remove_ < nc->GetLastCommittedEntryIndex()) {
-    content::NavigationEntry* entry =
-        nc->GetEntryAtIndex(history_index_to_remove_);
-    if (signin::IsContinueUrlForWebBasedSigninFlow(entry->GetURL())) {
-      hs->DeleteURL(entry->GetURL());
-      nc->RemoveEntryAtIndex(history_index_to_remove_);
-      delete this;  // Success.
-    }
-  }
 }
 
 void CurrentHistoryCleaner::WebContentsDestroyed() {
   delete this;  // Failure.
 }
 
 }  // namespace
 
 
 // StartSyncArgs --------------------------------------------------------------
@@ skipping 558 matching lines @@
     // complete.
     if (helper->original_continue_url_.is_empty())
       helper->original_continue_url_ = continue_url;
     helper->continue_url_ = continue_url;
   }
 }
 
 // static
 void OneClickSigninHelper::RemoveSigninRedirectURLHistoryItem(
     content::WebContents* web_contents) {
-  // Only actually remove the item if it's the blank.html continue url.
-  if (signin::IsContinueUrlForWebBasedSigninFlow(
-          web_contents->GetLastCommittedURL())) {
-    new CurrentHistoryCleaner(web_contents);  // will self-destruct when done
-  }
 }
 
 // static
 bool OneClickSigninHelper::HandleCrossAccountError(
     Profile* profile,
     const std::string& session_index,
     const std::string& email,
     const std::string& password,
     const std::string& refresh_token,
     OneClickSigninHelper::AutoAccept auto_accept,
@@ skipping 318 matching lines @@
       LogHistogramValue(signin_metrics::HISTOGRAM_WITH_DEFAULTS);
       SigninManager::DisableOneClickSignIn(profile->GetPrefs());
       // Start syncing with the default settings - prompt the user to sign in
       // first.
       if (!do_not_start_sync_for_testing_) {
         StartSync(
             StartSyncArgs(profile, browser, auto_accept_,
                           session_index_, email_, password_, "",
                           NULL  /* don't force sync setup in same tab */,
                           true  /* confirmation_required */, source_,
-                          CreateSyncStarterCallback()),
+                          OneClickSigninSyncStarter::Callback()),
             OneClickSigninSyncStarter::SYNC_WITH_DEFAULT_SETTINGS);
       }
       break;
     case AUTO_ACCEPT_CONFIGURE:
       LogHistogramValue(signin_metrics::HISTOGRAM_ACCEPTED);
       LogHistogramValue(signin_metrics::HISTOGRAM_WITH_ADVANCED);
       SigninManager::DisableOneClickSignIn(profile->GetPrefs());
       // Display the extra confirmation (even in the SAML case) in case this
       // was an untrusted renderer.
       if (!do_not_start_sync_for_testing_) {
         StartSync(
             StartSyncArgs(profile, browser, auto_accept_,
                           session_index_, email_, password_, "",
                           NULL  /* don't force sync setup in same tab */,
                           true  /* confirmation_required */, source_,
-                          CreateSyncStarterCallback()),
+                          OneClickSigninSyncStarter::Callback()),
             OneClickSigninSyncStarter::CONFIGURE_SYNC_FIRST);
       }
       break;
     case AUTO_ACCEPT_EXPLICIT: {
       signin_metrics::Source original_source =
           signin::GetSourceForPromoURL(original_continue_url_);
       if (switched_to_advanced_) {
         LogHistogramValue(signin_metrics::HISTOGRAM_WITH_ADVANCED);
         LogHistogramValue(signin_metrics::HISTOGRAM_ACCEPTED);
       } else {
@@ skipping 15 matching lines @@
       OneClickSigninSyncStarter::StartSyncMode start_mode =
           source_ == signin_metrics::SOURCE_SETTINGS ?
               (error_controller->HasError() &&
                sync_service && sync_service->HasSyncSetupCompleted()) ?
                   OneClickSigninSyncStarter::SHOW_SETTINGS_WITHOUT_CONFIGURE :
                   OneClickSigninSyncStarter::CONFIGURE_SYNC_FIRST :
               OneClickSigninSyncStarter::SYNC_WITH_DEFAULT_SETTINGS;
 
       if (!HandleCrossAccountError(profile, session_index_, email_, password_,
               "", auto_accept_, source_, start_mode,
-              CreateSyncStarterCallback())) {
+              OneClickSigninSyncStarter::Callback())) {
         if (!do_not_start_sync_for_testing_) {
           StartSync(
               StartSyncArgs(profile, browser, auto_accept_,
                             session_index_, email_, password_, "",
                             contents,
                             untrusted_confirmation_required_, source_,
-                            CreateSyncStarterCallback()),
+                            OneClickSigninSyncStarter::Callback()),
               start_mode);
         }
 
         // If this explicit sign in is not from settings page/webstore, show
         // the NTP/Apps page after sign in completes. In the case of the
         // settings page, it will get auto-closed after sync setup. In the case
         // of webstore, it will redirect back to webstore.
         RedirectToNtpOrAppsPageIfNecessary(web_contents(), source_);
       }
 
@@ skipping 10 matching lines @@
       AddEmailToOneClickRejectedList(profile, email_);
       LogHistogramValue(signin_metrics::HISTOGRAM_REJECTED);
       break;
     default:
       NOTREACHED() << "Invalid auto_accept=" << auto_accept_;
       break;
   }
 
   CleanTransientState();
 }
-
-OneClickSigninSyncStarter::Callback
-    OneClickSigninHelper::CreateSyncStarterCallback() {
-  // The callback will only be invoked if this object is still alive when sync
-  // setup is completed. This is correct because this object is only deleted
-  // when the web contents that potentially shows a blank page is deleted.
-  return base::Bind(&OneClickSigninHelper::SyncSetupCompletedCallback,
-                    weak_pointer_factory_.GetWeakPtr());
-}
-
-void OneClickSigninHelper::SyncSetupCompletedCallback(
-    OneClickSigninSyncStarter::SyncSetupResult result) {
-  if (result == OneClickSigninSyncStarter::SYNC_SETUP_FAILURE &&
-      web_contents()) {
-    GURL current_url = web_contents()->GetVisibleURL();
-
-    // If the web contents is showing a blank page and not about to be closed,
-    // redirect to the NTP or apps page.
-    if (signin::IsContinueUrlForWebBasedSigninFlow(current_url) &&
-        !signin::IsAutoCloseEnabledInURL(original_continue_url_)) {
-      RedirectToNtpOrAppsPage(
-          web_contents(),
-          signin::GetSourceForPromoURL(original_continue_url_));
-    }
-  }
-}