Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 872433006: Disconnect one click sign in code. The code itself will be removed in followup (Closed)

Created:
5 years, 11 months ago by Roger Tawa OOO till Jul 10th
Modified:
5 years, 10 months ago
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, chromoting-reviews_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disconnect one click sign in code. The code itself will be removed in followup CLs. BUG=260022, 350202 Committed: https://crrev.com/d32a8c3a333ec2b9338664034f58a056aa0b491a Cr-Commit-Position: refs/heads/master@{#317664}

Patch Set 1 : rebased #

Patch Set 2 : Fix gn file #

Patch Set 3 : rebased #

Patch Set 4 : rebased #

Total comments: 4

Patch Set 5 : forsync #

Patch Set 6 : rebased #

Patch Set 7 : Address review comments #

Patch Set 8 : rebased #

Total comments: 2

Patch Set 9 : Remove () #

Patch Set 10 : rebased #

Patch Set 11 : merged #

Patch Set 12 : rebased #

Patch Set 13 : Fix merge problem #

Patch Set 14 : merged #

Patch Set 15 : rebased #

Patch Set 16 : rebased #

Patch Set 17 : rebased #

Patch Set 18 : Fix merge #

Patch Set 19 : rebased #

Patch Set 20 : merged #

Patch Set 21 : Fix merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -562 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/first_run/first_run.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/password_manager/save_password_infobar_delegate.cc View 1 2 3 4 5 6 1 chunk +0 lines, -25 lines 0 comments Download
M chrome/browser/policy/chrome_browser_policy_connector.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/policy/chrome_browser_policy_connector.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/signin/chrome_signin_client.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/signin/signin_browsertest.cc View 1 chunk +0 lines, -265 lines 0 comments Download
M chrome/browser/signin/signin_header_helper.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/signin/signin_promo.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/signin/signin_promo.cc View 6 chunks +11 lines, -76 lines 0 comments Download
M chrome/browser/signin/signin_tracker_factory.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.cc View 8 chunks +5 lines, -82 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_starter.cc View 3 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/ui/tab_helpers.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 3 chunks +0 lines, -20 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/remoting/remote_desktop_browsertest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M components/signin/core/browser/about_signin_internals.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/signin/core/common/profile_management_switches.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/signin/core/common/profile_management_switches.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M components/signin/core/common/signin_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/signin/core/common/signin_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 26 (11 generated)
Roger Tawa OOO till Jul 10th
Hi Monica, Please take a look. Thanks.
5 years, 10 months ago (2015-01-30 15:31:43 UTC) #5
noms (inactive)
Holy cleanup, Batman! lgtm!
5 years, 10 months ago (2015-02-03 15:35:47 UTC) #6
Roger Tawa OOO till Jul 10th
Thanks Monica. Owners, please review: Gab: chrome/browser/first_run Ilya: chrome\browser\password_manager Drew: chrome\browser\policy Scott: chrome\browser\ui chrome\test
5 years, 10 months ago (2015-02-04 13:07:35 UTC) #8
gab
https://codereview.chromium.org/872433006/diff/120001/chrome/browser/first_run/first_run.cc File chrome/browser/first_run/first_run.cc (right): https://codereview.chromium.org/872433006/diff/120001/chrome/browser/first_run/first_run.cc#newcode368 chrome/browser/first_run/first_run.cc:368: // URL for the sign in page or the ...
5 years, 10 months ago (2015-02-04 13:21:03 UTC) #9
sky
I'm not familiar with c/b/u/sync. Could you find a more local owner for those files? ...
5 years, 10 months ago (2015-02-04 18:44:55 UTC) #10
Ilya Sherman
//chrome/browser/password_manager/save_password_infobar_delegate.cc LGTM
5 years, 10 months ago (2015-02-04 23:04:25 UTC) #11
Ilya Sherman
Actually, one nit: https://codereview.chromium.org/872433006/diff/120001/chrome/browser/password_manager/save_password_infobar_delegate.cc File chrome/browser/password_manager/save_password_infobar_delegate.cc (right): https://codereview.chromium.org/872433006/diff/120001/chrome/browser/password_manager/save_password_infobar_delegate.cc#newcode16 chrome/browser/password_manager/save_password_infobar_delegate.cc:16: #include "google_apis/gaia/gaia_urls.h" nit: Can this be ...
5 years, 10 months ago (2015-02-04 23:05:36 UTC) #12
Roger Tawa OOO till Jul 10th
Thanks guys. Drew: can you also look at chrome/browser/ui/sync? Thanks. https://codereview.chromium.org/872433006/diff/120001/chrome/browser/first_run/first_run.cc File chrome/browser/first_run/first_run.cc (right): https://codereview.chromium.org/872433006/diff/120001/chrome/browser/first_run/first_run.cc#newcode368 ...
5 years, 10 months ago (2015-02-09 16:52:25 UTC) #14
Andrew T Wilson (Slow)
On 2015/02/09 16:52:25, Roger Tawa wrote: > Thanks guys. > > Drew: can you also ...
5 years, 10 months ago (2015-02-10 10:01:47 UTC) #16
gab
c/b/first_run lgtm w/ nit https://codereview.chromium.org/872433006/diff/220001/chrome/browser/first_run/first_run.cc File chrome/browser/first_run/first_run.cc (right): https://codereview.chromium.org/872433006/diff/220001/chrome/browser/first_run/first_run.cc#newcode373 chrome/browser/first_run/first_run.cc:373: (contents->GetURL() == nit: Would you ...
5 years, 10 months ago (2015-02-10 15:13:10 UTC) #17
Roger Tawa OOO till Jul 10th
https://codereview.chromium.org/872433006/diff/220001/chrome/browser/first_run/first_run.cc File chrome/browser/first_run/first_run.cc (right): https://codereview.chromium.org/872433006/diff/220001/chrome/browser/first_run/first_run.cc#newcode373 chrome/browser/first_run/first_run.cc:373: (contents->GetURL() == On 2015/02/10 15:13:09, gab wrote: > nit: ...
5 years, 10 months ago (2015-02-10 15:48:29 UTC) #19
Andrew T Wilson (Slow)
ui/sync lgtm, but only to land in M43, not M42 per our offline discussion.
5 years, 10 months ago (2015-02-11 12:20:03 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872433006/500001
5 years, 10 months ago (2015-02-23 21:10:45 UTC) #24
commit-bot: I haz the power
Committed patchset #21 (id:500001)
5 years, 10 months ago (2015-02-23 22:16:19 UTC) #25
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 22:17:29 UTC) #26
Message was sent while issue was closed. 
Patchset 21 (id:??) landed as
https://crrev.com/d32a8c3a333ec2b9338664034f58a056aa0b491a
Cr-Commit-Position: refs/heads/master@{#317664}

Powered by Google App Engine
This is Rietveld 408576698