Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 872433005: Move capture scheduling logic from VideoScheduler to CaptureScheduler. (Closed)

Created:
5 years, 11 months ago by Sergey Ulanov
Modified:
5 years, 10 months ago
Reviewers:
Wez
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move capture scheduling logic from VideoScheduler to CaptureScheduler. BUG=455818 Committed: https://crrev.com/91f93b66946793715f5877fc696f626dc6812dbf Cr-Commit-Position: refs/heads/master@{#314864}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Total comments: 20

Patch Set 5 : #

Total comments: 5

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+405 lines, -328 lines) Patch
M remoting/host/capture_scheduler.h View 1 2 3 4 5 1 chunk +55 lines, -9 lines 0 comments Download
M remoting/host/capture_scheduler.cc View 1 2 3 4 2 chunks +96 lines, -16 lines 0 comments Download
M remoting/host/capture_scheduler_unittest.cc View 1 2 3 4 5 5 chunks +101 lines, -33 lines 0 comments Download
M remoting/host/client_session.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M remoting/host/video_scheduler.h View 1 2 3 4 7 chunks +27 lines, -49 lines 0 comments Download
M remoting/host/video_scheduler.cc View 1 2 3 4 9 chunks +123 lines, -220 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
Sergey Ulanov
This should simplify the ACKs CL (https://codereview.chromium.org/850983002/) and make it easier to unittest it.
5 years, 11 months ago (2015-01-27 21:59:56 UTC) #2
Sergey Ulanov
CL description was incorrect, renamed it (s/thread scheduling/capture scheduling/)
5 years, 11 months ago (2015-01-27 22:00:53 UTC) #3
Wez
This CL seems to add a lot of code to CaptureScheduler without really simplifying VideoScheduler ...
5 years, 10 months ago (2015-02-02 21:40:49 UTC) #4
Sergey Ulanov
On 2015/02/02 21:40:49, Wez wrote: > This CL seems to add a lot of code ...
5 years, 10 months ago (2015-02-03 20:25:22 UTC) #5
Sergey Ulanov
Simplified VideoScheduler by moving CaptureScheduler to the network thread. Added TODOs for the other work ...
5 years, 10 months ago (2015-02-03 23:49:52 UTC) #6
Wez
lgtm https://codereview.chromium.org/872433005/diff/60001/remoting/host/capture_scheduler.cc File remoting/host/capture_scheduler.cc (right): https://codereview.chromium.org/872433005/diff/60001/remoting/host/capture_scheduler.cc#newcode67 remoting/host/capture_scheduler.cc:67: capture_timer_->Stop(); On 2015/02/03 23:49:52, Sergey Ulanov wrote: > ...
5 years, 10 months ago (2015-02-05 02:40:25 UTC) #7
Sergey Ulanov
https://codereview.chromium.org/872433005/diff/80001/remoting/host/capture_scheduler.h File remoting/host/capture_scheduler.h (right): https://codereview.chromium.org/872433005/diff/80001/remoting/host/capture_scheduler.h#newcode85 remoting/host/capture_scheduler.h:85: // Time the last capture started. Used to schedule ...
5 years, 10 months ago (2015-02-05 19:13:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872433005/100001
5 years, 10 months ago (2015-02-05 19:14:50 UTC) #11
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 10 months ago (2015-02-05 20:15:01 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 20:15:44 UTC) #13
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/91f93b66946793715f5877fc696f626dc6812dbf
Cr-Commit-Position: refs/heads/master@{#314864}

Powered by Google App Engine
This is Rietveld 408576698