Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3544)

Unified Diff: chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc

Issue 872433003: Remove omnibox watcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
diff --git a/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc b/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
index 71df77e368135e0414f0c9f3157d217f49517134..236aae45af138738b2594857ca3b508eb49e7d7c 100644
--- a/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
+++ b/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
@@ -27,7 +27,6 @@
#include "chrome/browser/safe_browsing/incident_reporting/environment_data_collection.h"
#include "chrome/browser/safe_browsing/incident_reporting/incident.h"
#include "chrome/browser/safe_browsing/incident_reporting/incident_report_uploader_impl.h"
-#include "chrome/browser/safe_browsing/incident_reporting/omnibox_watcher.h"
#include "chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.h"
#include "chrome/browser/safe_browsing/safe_browsing_service.h"
#include "chrome/common/pref_names.h"
@@ -156,9 +155,6 @@ struct IncidentReportingService::ProfileContext {
// Will contain null values for pruned incidents.
ScopedVector<Incident> incidents;
- // Watches for suspicious omnibox interactions on this profile.
- scoped_ptr<OmniboxWatcher> omnibox_watcher;
-
// False until PROFILE_ADDED notification is received.
bool added;
@@ -364,11 +360,6 @@ void IncidentReportingService::OnProfileAdded(Profile* profile) {
// so that the service can determine whether or not it can evaluate a
// profile's preferences at the time of incident addition.
ProfileContext* context = GetOrCreateProfileContext(profile);
- // Start watching the profile now if necessary.
- if (!context->omnibox_watcher) {
- context->omnibox_watcher.reset(
- new OmniboxWatcher(profile, GetAddIncidentCallback(profile)));
- }
context->added = true;
const bool safe_browsing_enabled =

Powered by Google App Engine
This is Rietveld 408576698