Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: net/quic/quic_ack_notifier.h

Issue 872403007: Remove an unneeded hash_set from QuicAckNotifierManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Minor_cleanup_84624803
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_ack_notifier.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_ack_notifier.h
diff --git a/net/quic/quic_ack_notifier.h b/net/quic/quic_ack_notifier.h
index 10082ee67269f2281a458bf9224d2d7def5e4e95..b9b1cc67a5e06a73c13a68efbb01e3f2e4a19c9a 100644
--- a/net/quic/quic_ack_notifier.h
+++ b/net/quic/quic_ack_notifier.h
@@ -54,7 +54,12 @@ class NET_EXPORT_PRIVATE QuicAckNotifier {
bool OnAck(QuicPacketSequenceNumber sequence_number,
QuicTime::Delta delta_largest_observed);
- bool IsEmpty() { return unacked_packets_ == 0; }
+ // Called when we've given up waiting for a sequence number, typically when
+ // the connection is torn down.
+ // Returns true if there are no more unacked packets being tracked.
+ bool OnPacketAbandoned();
+
+ bool HasUnackedPackets() const { return unacked_packets_ > 0; }
// If a packet is retransmitted by the connection, it will be sent with a
// different sequence number.
« no previous file with comments | « no previous file | net/quic/quic_ack_notifier.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698