aw: Make repeated detachGLFunctor work

aw: Make repeated detachGLFunctor work

detachGLFunctor is called every time the webview is detached (ie when
hardware acceleration is torn down and cleaned up). This can happen many
times since webview can be attached and detached many times.

However the implementation in the glue layer only does something on the
first call.

Also in general, it's a bad pattern for CleanupReference to have strong
java refs.

It's not necessary to call detachGLFunctor on gc; detach is enough. So
move all that code out of the DestroyRunnable of the CleanupReference.

This is a long standing bug since the first release of chromium webview.

BUG=

Committed: https://crrev.com/72cf6e83b26d24af3c1b270f839911dfaddf2d46
Cr-Commit-Position: refs/heads/master@{#315051}

[boliu, 2015-02-06 00:18:50]

boliu@chromium.org changed reviewers:
+ torne@chromium.org

[boliu, 2015-02-06 00:18:51]

torne for review

And a question. I'm not planning on merging this anywhere, but should glue
changes go somewhere else in the android tree?

[Torne, 2015-02-06 11:45:09]

On 2015/02/06 00:18:51, boliu wrote:
> torne for review

LGTM

> And a question. I'm not planning on merging this anywhere, but should glue
> changes go somewhere else in the android tree?

No, it can just go here if you aren't merging it to release branches. The
downstream copy of the glue layer has been deleted in master-chromium and we use
this copy even for downstream builds now. :)

[boliu, 2015-02-06 16:29:10]

On 2015/02/06 11:45:09, Torne wrote:
> On 2015/02/06 00:18:51, boliu wrote:
> > torne for review
> 
> LGTM
> 
> > And a question. I'm not planning on merging this anywhere, but should glue
> > changes go somewhere else in the android tree?
> 
> No, it can just go here if you aren't merging it to release branches. The
> downstream copy of the glue layer has been deleted in master-chromium and we
use
> this copy even for downstream builds now. :)

Yay!

[boliu, 2015-02-06 16:35:20]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2015-02-06 16:36:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/872403006/1

[commit-bot: I haz the power, 2015-02-06 17:12:41]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-06 17:13:28]

Patchset 1 (id:??) landed as
https://crrev.com/72cf6e83b26d24af3c1b270f839911dfaddf2d46
Cr-Commit-Position: refs/heads/master@{#315051}