Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 872393003: MIPS: remove immediate constraint within CompareAndSwap. (Closed)

Created:
5 years, 11 months ago by gordanac
Modified:
5 years, 11 months ago
Reviewers:
Nico, agl
CC:
chromium-reviews, erikwright+watch_chromium.org, Paul Lind, petar.jovanovic, petarj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MIPS: remove immediate constraint within CompareAndSwap. Improper use of immediate constraint is slightly non-optimal with gcc/gnu-as but may cause breakage with clang. BUG= Committed: https://crrev.com/8bd6f985f24f3ab29fbfd325e678121f33dd3518 Cr-Commit-Position: refs/heads/master@{#313302}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/atomicops_internals_mips_gcc.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
gordanac
Please take a look.
5 years, 11 months ago (2015-01-26 14:20:23 UTC) #2
agl
lgtm
5 years, 11 months ago (2015-01-26 21:28:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872393003/1
5 years, 11 months ago (2015-01-26 21:29:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/38407) Try jobs failed on following ...
5 years, 11 months ago (2015-01-26 21:37:25 UTC) #7
gordanac
+thakis as base OWNER approval is needed.
5 years, 11 months ago (2015-01-27 11:34:19 UTC) #9
Nico
rs-lgtm
5 years, 11 months ago (2015-01-27 17:15:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872393003/1
5 years, 11 months ago (2015-01-27 17:16:44 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/38407)
5 years, 11 months ago (2015-01-27 17:17:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872393003/1
5 years, 11 months ago (2015-01-27 17:49:56 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 17:51:14 UTC) #17
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 17:52:21 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8bd6f985f24f3ab29fbfd325e678121f33dd3518
Cr-Commit-Position: refs/heads/master@{#313302}

Powered by Google App Engine
This is Rietveld 408576698