Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 872373002: Fix gamepad/page-visibility.html flakiness. (Closed)

Created:
5 years, 11 months ago by sof
Modified:
5 years, 11 months ago
Reviewers:
haraken, Mike West
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix gamepad/page-visibility.html flakiness. If the running of the individual tests took longer, we ran the risk of having a bail-out timer fire and report foul; in debug builds typically. Not a failure condition to be slow(er) here. Remove that bail-out timer; should the delivery of gamepad events somehow not be complete, just let the test time out & report failure that way. R=haraken BUG=386846 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188950

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M LayoutTests/gamepad/page-visibility.html View 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
Please take a look. (Ran across the flakiness while looking at crbug.com/357071 )
5 years, 11 months ago (2015-01-26 10:41:36 UTC) #2
haraken
LGTM
5 years, 11 months ago (2015-01-26 11:24:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872373002/1
5 years, 11 months ago (2015-01-26 11:38:29 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 11:57:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188950

Powered by Google App Engine
This is Rietveld 408576698