Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Issue 872363002: [turbofan] Add new JSIntrinsicsLowering reducer. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add new JSIntrinsicsLowering reducer. The lowering of intrinsics is therefore now decoupled from the general inlining logic. TEST=cctest,unittests R=svenpanne@chromium.org Committed: https://crrev.com/4f1597a92daddd529207cf86b6aaf9baa6f3adc2 Cr-Commit-Position: refs/heads/master@{#26263}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+455 lines, -299 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/js-inlining.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-inlining.cc View 3 chunks +3 lines, -73 lines 0 comments Download
D src/compiler/js-intrinsic-builder.h View 1 chunk +0 lines, -40 lines 0 comments Download
D src/compiler/js-intrinsic-builder.cc View 1 chunk +0 lines, -140 lines 0 comments Download
A + src/compiler/js-intrinsic-lowering.h View 3 chunks +16 lines, -15 lines 0 comments Download
A src/compiler/js-intrinsic-lowering.cc View 1 chunk +194 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-intrinsics.cc View 18 chunks +0 lines, -18 lines 0 comments Download
A test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 1 chunk +215 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 11 months ago (2015-01-26 08:26:08 UTC) #1
Benedikt Meurer
PTAL
5 years, 11 months ago (2015-01-26 08:27:05 UTC) #2
Sven Panne
lgtm
5 years, 11 months ago (2015-01-26 08:35:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872363002/1
5 years, 11 months ago (2015-01-26 08:35:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-26 09:05:55 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 09:06:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f1597a92daddd529207cf86b6aaf9baa6f3adc2
Cr-Commit-Position: refs/heads/master@{#26263}

Powered by Google App Engine
This is Rietveld 408576698