Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: chrome/browser/history/DEPS

Issue 872313005: Remove dependency on visitedlink from history (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@init-prefs
Patch Set: Rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 include_rules = [ 1 include_rules = [
2 # History is being made into a Browser Component (http://crbug.com/370850), so 2 # History is being made into a Browser Component (http://crbug.com/370850), so
3 # we have these basic rules followed by temporary exceptions. Please don't 3 # we have these basic rules followed by temporary exceptions. Please don't
4 # add to the list of exceptions! 4 # add to the list of exceptions!
5 # 5 #
6 # Please send reviews to sdefresne@chromium.org when adding dependencies to 6 # Please send reviews to sdefresne@chromium.org when adding dependencies to
7 # this list. 7 # this list.
8 "-chrome/browser", 8 "-chrome/browser",
9 "-components", 9 "-components",
10 10
(...skipping 11 matching lines...) Expand all
22 "!chrome/browser/prerender/prerender_contents.h", 22 "!chrome/browser/prerender/prerender_contents.h",
23 "!chrome/browser/prerender/prerender_manager.h", 23 "!chrome/browser/prerender/prerender_manager.h",
24 "!chrome/browser/prerender/prerender_manager_factory.h", 24 "!chrome/browser/prerender/prerender_manager_factory.h",
25 "!chrome/browser/profiles/incognito_helpers.h", 25 "!chrome/browser/profiles/incognito_helpers.h",
26 "!chrome/browser/profiles/profile.h", 26 "!chrome/browser/profiles/profile.h",
27 "!chrome/browser/profiles/profile_manager.h", 27 "!chrome/browser/profiles/profile_manager.h",
28 "!chrome/browser/ui/browser.h", 28 "!chrome/browser/ui/browser.h",
29 "!chrome/browser/ui/browser_finder.h", 29 "!chrome/browser/ui/browser_finder.h",
30 "!components/bookmarks/browser/bookmark_utils.h", 30 "!components/bookmarks/browser/bookmark_utils.h",
31 "!components/dom_distiller/core/url_constants.h", 31 "!components/dom_distiller/core/url_constants.h",
32 "!components/visitedlink/browser/visitedlink_delegate.h",
33 "!components/visitedlink/browser/visitedlink_master.h",
34 ] 32 ]
35 33
36 specific_include_rules = { 34 specific_include_rules = {
37 # Browser tests, by definition, need access to the browser objects. 35 # Browser tests, by definition, need access to the browser objects.
38 '.*_(api|browser|)test\.cc': [ 36 '.*_(api|browser|)test\.cc': [
39 "+chrome/browser", 37 "+chrome/browser",
40 ], 38 ],
41 # chrome_.* and .*_factory won't be componentized as they belong to the 39 # chrome_.* and .*_factory won't be componentized as they belong to the
42 # embedder, so they can depend on other feature in chrome/. Same thing 40 # embedder, so they can depend on other feature in chrome/. Same thing
43 # for android specific code. 41 # for android specific code.
44 '(chrome_.*|.*_factory)\.(cc|h)': [ 42 '(chrome_.*|.*_factory)\.(cc|h)': [
45 "+chrome/browser/bookmarks/bookmark_model_factory.h", 43 "+chrome/browser/bookmarks/bookmark_model_factory.h",
46 "+chrome/browser/bookmarks/chrome_bookmark_client.h", 44 "+chrome/browser/bookmarks/chrome_bookmark_client.h",
47 "+chrome/browser/bookmarks/chrome_bookmark_client_factory.h", 45 "+chrome/browser/bookmarks/chrome_bookmark_client_factory.h",
48 "+chrome/browser/content_settings/cookie_settings.h", 46 "+chrome/browser/content_settings/cookie_settings.h",
49 "+chrome/browser/signin/profile_oauth2_token_service_factory.h", 47 "+chrome/browser/signin/profile_oauth2_token_service_factory.h",
50 "+chrome/browser/signin/signin_manager_factory.h", 48 "+chrome/browser/signin/signin_manager_factory.h",
51 "+chrome/browser/sync/profile_sync_service.h", 49 "+chrome/browser/sync/profile_sync_service.h",
52 "+chrome/browser/sync/profile_sync_service_factory.h", 50 "+chrome/browser/sync/profile_sync_service_factory.h",
53 "+chrome/browser/ui/profile_error_dialog.h", 51 "+chrome/browser/ui/profile_error_dialog.h",
54 "+components/bookmarks/browser", 52 "+components/bookmarks/browser",
55 "+components/keyed_service/content", 53 "+components/keyed_service/content",
56 ], 54 ],
55 # Those files will move to //components/history/content/browser and thus
56 # can depend on //content even indirectly.
57 'content_.*\.(cc|h)': [
58 "+components/visitedlink/browser",
59 ],
57 # TODO(sdefresne): Bring this list to zero. 60 # TODO(sdefresne): Bring this list to zero.
58 # 61 #
59 # Do not add to the list of temporarily-allowed dependencies below, 62 # Do not add to the list of temporarily-allowed dependencies below,
60 # and please do not introduce more #includes of these files. 63 # and please do not introduce more #includes of these files.
61 '.*_[a-z]*test\.cc': [ 64 '.*_[a-z]*test\.cc': [
62 "!chrome/browser/autocomplete/scored_history_match_builder_impl.h", 65 "!chrome/browser/autocomplete/scored_history_match_builder_impl.h",
63 "!chrome/browser/bookmarks/bookmark_model_factory.h", 66 "!chrome/browser/bookmarks/bookmark_model_factory.h",
64 "!chrome/browser/signin/profile_oauth2_token_service_factory.h", 67 "!chrome/browser/signin/profile_oauth2_token_service_factory.h",
65 "!chrome/browser/signin/signin_manager_factory.h", 68 "!chrome/browser/signin/signin_manager_factory.h",
66 "!chrome/browser/sync/profile_sync_service.h", 69 "!chrome/browser/sync/profile_sync_service.h",
67 "!chrome/browser/sync/profile_sync_service_factory.h", 70 "!chrome/browser/sync/profile_sync_service_factory.h",
68 "!chrome/browser/sync/profile_sync_service_mock.h", 71 "!chrome/browser/sync/profile_sync_service_mock.h",
69 "!components/bookmarks/test/bookmark_test_helpers.h", 72 "!components/bookmarks/test/bookmark_test_helpers.h",
70 ] 73 ]
71 } 74 }
OLDNEW
« no previous file with comments | « chrome/browser/autocomplete/shortcuts_provider_unittest.cc ('k') | chrome/browser/history/content_visit_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698