Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 872313003: Move Notification-related Blink API headers into their own directory. (Closed)

Created:
5 years, 10 months ago by Peter Beverloo
Modified:
5 years, 10 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move Notification-related Blink API headers into their own directory. This allows the Notification APIs to be covered by a notification OWNER on top of the other public/ OWNERS. This is part of a three-sided patch: [1] This patch. [2] https://codereview.chromium.org/893993002/ [3] https://codereview.chromium.org/869343005/ BUG=453032 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189497

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -198 lines) Patch
M Source/modules/notifications/Notification.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/notifications/Notification.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/NotificationPermissionClientImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebNotificationData.h View 1 chunk +1 line, -45 lines 0 comments Download
M public/platform/WebNotificationDelegate.h View 1 chunk +1 line, -23 lines 0 comments Download
M public/platform/WebNotificationManager.h View 1 chunk +1 line, -51 lines 0 comments Download
M public/platform/WebNotificationPermission.h View 1 chunk +1 line, -20 lines 0 comments Download
A + public/platform/modules/notifications/OWNERS View 0 chunks +-1 lines, --1 lines 1 comment Download
A + public/platform/modules/notifications/WebNotificationData.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + public/platform/modules/notifications/WebNotificationDelegate.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/platform/modules/notifications/WebNotificationManager.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + public/platform/modules/notifications/WebNotificationPermission.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M public/web/WebNotificationPermissionCallback.h View 1 chunk +1 line, -50 lines 0 comments Download
A + public/web/modules/notifications/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/web/modules/notifications/WebNotificationPermissionCallback.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Peter Beverloo
+jochen for the public/ module changes for Notifications.
5 years, 10 months ago (2015-02-02 12:47:49 UTC) #2
Mike West
LGTM. https://codereview.chromium.org/872313003/diff/20001/public/platform/modules/notifications/OWNERS File public/platform/modules/notifications/OWNERS (right): https://codereview.chromium.org/872313003/diff/20001/public/platform/modules/notifications/OWNERS#newcode1 public/platform/modules/notifications/OWNERS:1: peter@chromium.org You might want to add more OWNERS ...
5 years, 10 months ago (2015-02-02 13:16:46 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 10 months ago (2015-02-04 12:33:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872313003/20001
5 years, 10 months ago (2015-02-04 12:35:19 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 13:25:31 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189497

Powered by Google App Engine
This is Rietveld 408576698