Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 872263005: Allow supervised users to delete profiles in about:settings. (Closed)

Created:
5 years, 10 months ago by Marc Treib
Modified:
5 years, 10 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow supervised users to delete profiles in about:settings. They can already do the same via the new user manager. Also, allow child users to edit their name via about:settings -> Edit. Same reason. BUG=456744 Committed: https://crrev.com/5a6f3cb61a988fca479f373e65f1ef181a3df5a9 Cr-Commit-Position: refs/heads/master@{#315297}

Patch Set 1 #

Patch Set 2 : fix tests #

Patch Set 3 : fix #

Total comments: 3

Patch Set 4 : review #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -53 lines) Patch
M chrome/browser/resources/options/browser_options_profile_list.js View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/manage_profile_overlay.js View 1 2 3 5 chunks +4 lines, -8 lines 1 comment Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_browsertest.js View 1 2 chunks +3 lines, -35 lines 0 comments Download
M chrome/browser/ui/webui/options/options_handlers_helper.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Marc Treib
Please review! https://codereview.chromium.org/872263005/diff/30001/chrome/browser/ui/webui/options/manage_profile_browsertest.js File chrome/browser/ui/webui/options/manage_profile_browsertest.js (left): https://codereview.chromium.org/872263005/diff/30001/chrome/browser/ui/webui/options/manage_profile_browsertest.js#oldcode526 chrome/browser/ui/webui/options/manage_profile_browsertest.js:526: TEST_F('ManageProfileUITest', 'SupervisedDelete', function() { We could also ...
5 years, 10 months ago (2015-02-09 12:04:00 UTC) #2
Bernhard Bauer
lgtm https://codereview.chromium.org/872263005/diff/30001/chrome/browser/resources/options/manage_profile_overlay.js File chrome/browser/resources/options/manage_profile_overlay.js (right): https://codereview.chromium.org/872263005/diff/30001/chrome/browser/resources/options/manage_profile_overlay.js#newcode571 chrome/browser/resources/options/manage_profile_overlay.js:571: !(profileInfo.isSupervised && !profileInfo.isChild); Normalize this to `!profileInfo.isSupervised || ...
5 years, 10 months ago (2015-02-09 12:13:48 UTC) #3
Marc Treib
https://codereview.chromium.org/872263005/diff/30001/chrome/browser/resources/options/manage_profile_overlay.js File chrome/browser/resources/options/manage_profile_overlay.js (right): https://codereview.chromium.org/872263005/diff/30001/chrome/browser/resources/options/manage_profile_overlay.js#newcode571 chrome/browser/resources/options/manage_profile_overlay.js:571: !(profileInfo.isSupervised && !profileInfo.isChild); On 2015/02/09 12:13:48, Bernhard Bauer wrote: ...
5 years, 10 months ago (2015-02-09 12:20:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872263005/50001
5 years, 10 months ago (2015-02-09 12:20:55 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:50001)
5 years, 10 months ago (2015-02-09 14:51:25 UTC) #8
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/5a6f3cb61a988fca479f373e65f1ef181a3df5a9 Cr-Commit-Position: refs/heads/master@{#315297}
5 years, 10 months ago (2015-02-09 14:52:11 UTC) #9
Dan Beam
5 years, 10 months ago (2015-02-09 22:20:33 UTC) #11
Message was sent while issue was closed. 
https://codereview.chromium.org/872263005/diff/50001/chrome/browser/resources...
File chrome/browser/resources/options/manage_profile_overlay.js (right):

https://codereview.chromium.org/872263005/diff/50001/chrome/browser/resources...
chrome/browser/resources/options/manage_profile_overlay.js:538:
profileInfo.isSupervised && !profileInfo.isChild;
this broke the closure compile:
http://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Lin...

Powered by Google App Engine
This is Rietveld 408576698