Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 872253008: Passing key frame info flag renderer to browser process (Closed)

Created:
5 years, 11 months ago by qinmin
Modified:
5 years, 10 months ago
Reviewers:
Tom Sepez, wolenetz
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Passing key frame info flag renderer to browser process For MediaSourcePlayer, we can use this flag to reduce the browser seek when codec is recreated. Will implement the logic to reduce browser seek in a follow up CL. BUG=304234 Committed: https://crrev.com/6f185c3f517b95fcfbeff5c8361aba5389c4215e Cr-Commit-Position: refs/heads/master@{#313579}

Patch Set 1 #

Patch Set 2 : rename end_of_stream to is_end_of_stream #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M content/common/media/media_player_messages_android.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/android/media_source_delegate.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M media/base/android/demuxer_stream_player_params.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M media/base/android/demuxer_stream_player_params.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/media_decoder_job.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M media/base/android/media_source_player_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
qinmin
PTAL
5 years, 11 months ago (2015-01-27 01:22:25 UTC) #2
qinmin
+tsepez for ipc/
5 years, 10 months ago (2015-01-28 18:11:25 UTC) #4
Tom Sepez
Messages LGTM
5 years, 10 months ago (2015-01-28 18:14:07 UTC) #5
wolenetz
lgtm. There's a little inconsistency around the naming of the new field: "end_of_stream" vs "is_key_frame". ...
5 years, 10 months ago (2015-01-28 18:26:18 UTC) #6
qinmin
renamed end_of_stream to is_end_of_stream
5 years, 10 months ago (2015-01-28 19:39:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872253008/20001
5 years, 10 months ago (2015-01-28 19:41:18 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-28 20:57:53 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 20:58:43 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6f185c3f517b95fcfbeff5c8361aba5389c4215e
Cr-Commit-Position: refs/heads/master@{#313579}

Powered by Google App Engine
This is Rietveld 408576698