Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 872243004: Fix 'gn check' errors in //ui/* targets. (Closed)

Created:
5 years, 11 months ago by tfarina
Modified:
5 years, 10 months ago
Reviewers:
brettw, sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Ian Vollick, tfarina, sievers+watch_chromium.org, jbauman+watch_chromium.org, oshima+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, stevenjb+watch_chromium.org, brettw, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix 'gn check' errors in //ui/* targets. Tested with the following configs: Linux: $ gn gen out_gn/Debug $ gn check out_gn/Debug Android: $ gn gen --args='os="android" cpu_arch="arm"' out_gn_android/Debug $ gn check out_gn_android/Debug Chromeos: $ gn gen --args='os="chromeos"' out_gn_chromeos/Debug $ gn check out_gn_chromeos/Debug BUG=367595, 376000 TEST=see above R=brettw@chromium.org TBR=sky@chromium.org Committed: https://crrev.com/cb1ffc60dc2b70da6676b5112b5bad0bb785f757 Cr-Commit-Position: refs/heads/master@{#314102}

Patch Set 1 #

Patch Set 2 : some android fixes & remove ui/ from .gn #

Patch Set 3 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -7 lines) Patch
M .gn View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/views/app_list_main_view_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/BUILD.gn View 1 2 4 chunks +9 lines, -3 lines 0 comments Download
M ui/base/ui_base.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/chromeos/BUILD.gn View 3 chunks +4 lines, -1 line 0 comments Download
M ui/compositor/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/display/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/ipc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/snapshot/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/views_content_client/BUILD.gn View 1 chunk +7 lines, -0 lines 0 comments Download
M ui/web_dialogs/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
tfarina
Depends on https://codereview.chromium.org/871813004/
5 years, 11 months ago (2015-01-25 17:55:54 UTC) #1
brettw
lgtm
5 years, 11 months ago (2015-01-26 06:03:39 UTC) #3
tfarina
I removed //ui/* from .gn, so it should be fine to land without having to ...
5 years, 11 months ago (2015-01-26 15:12:37 UTC) #4
tfarina
Pushing to CQ!
5 years, 10 months ago (2015-02-02 01:18:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872243004/40001
5 years, 10 months ago (2015-02-02 01:19:02 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-02 02:56:11 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 02:57:13 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cb1ffc60dc2b70da6676b5112b5bad0bb785f757
Cr-Commit-Position: refs/heads/master@{#314102}

Powered by Google App Engine
This is Rietveld 408576698