Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 872243003: Don't do a pointless << 0. (Closed)

Created:
5 years, 11 months ago by mtklein_C
Modified:
5 years, 11 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Don't do a pointless << 0. It's very common (universal?) that alpha is the top byte. You'd hope the compiler would remove the left shift then, but I've seen Clang just do a dumb left shift of zero. :( BUG=skia: Committed: https://skia.googlesource.com/skia/+/8d029a4ebeda9d99c40b864e9c93c55be58b05af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/opts/SkColor_opts_SSE2.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mtklein
5 years, 11 months ago (2015-01-25 16:30:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872243003/1
5 years, 11 months ago (2015-01-25 16:31:37 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-25 16:31:38 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 11 months ago (2015-01-25 22:31:39 UTC) #7
reed1
lgtm
5 years, 11 months ago (2015-01-26 15:06:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/872243003/1
5 years, 11 months ago (2015-01-26 15:06:59 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 15:07:06 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8d029a4ebeda9d99c40b864e9c93c55be58b05af

Powered by Google App Engine
This is Rietveld 408576698